linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/2] Use architected timers for delay loop
Date: Tue, 26 Jun 2012 11:35:18 +0100	[thread overview]
Message-ID: <20120626103518.GC27996@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <4FE8DA65.8030403@codeaurora.org>

Hi Stephen,

Thanks for taking a look at the series!

On Mon, Jun 25, 2012 at 10:38:45PM +0100, Stephen Boyd wrote:
> On 06/22/12 08:09, Will Deacon wrote:
> > This patch series reworks our delay loop implementation to allow the
> > busy-loop to be replaced with the physical counter included as part of
> > the architected timer on recent CPUs. The polling implementation is
> > still maintained to support cores without the timers and we use the same
> > maths and upper delay bound of 2ms.
> 
> I have posted a read_current_timer implementation to the list a couple
> times but had no success in getting it merged. The patches are still in
> the patch tracker but I haven't really pushed them to get merged.
> 
>     http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=6874/1
>     http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=6873/1
>     http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=6875/1

I took a look at these but I really shy away from using memory-mapped
clocksources for delay -- it feels like we're asking for problems if we go
down that route. Maybe it could work, but switching from the polling loop to
the clocksource would surely require some recalibration?

> So far we've just been carrying them internally. I suppose ARM needs
> this now because of big little?

To be honest, I just implemented this because it allows us to skip the
calibration and I thought the solution fell out quite neatly. It does also
remove the need for re-calibration when scaling the core clock, so yes it
would be useful whenever that occurs.

Will

  reply	other threads:[~2012-06-26 10:35 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-22 15:09 [PATCH 0/2] Use architected timers for delay loop Will Deacon
2012-06-22 15:09 ` [PATCH 1/2] ARM: arch timer: implement read_current_timer and get_cycles Will Deacon
2012-06-25 21:39   ` Stephen Boyd
2012-06-26 10:37     ` Will Deacon
2012-06-26 17:44       ` Stephen Boyd
2012-06-22 15:09 ` [PATCH 2/2] ARM: delay: allow timer-based delay implementation to be selected Will Deacon
2012-06-25 21:39   ` Stephen Boyd
2012-06-26 10:49     ` Will Deacon
2012-06-26 15:54       ` Will Deacon
2012-06-26 16:00         ` Rob Herring
2012-06-26 16:28           ` Will Deacon
2012-06-27  2:07       ` Stephen Boyd
2012-06-27  9:41         ` Will Deacon
2012-06-22 22:26 ` [PATCH 0/2] Use architected timers for delay loop Russell King - ARM Linux
2012-06-25 10:03   ` Will Deacon
2012-06-25 21:38 ` Stephen Boyd
2012-06-26 10:35   ` Will Deacon [this message]
2012-06-26 17:42     ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120626103518.GC27996@mudshark.cambridge.arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).