linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM:MX28: Add additionnal muxing options to iMX28 DTSI
Date: Tue, 26 Jun 2012 11:02:02 +0200	[thread overview]
Message-ID: <20120626110202.06807982@skate> (raw)
In-Reply-To: <20120625155047.GD2342@S2101-09.ap.freescale.net>

Hello Shawn,

Le Mon, 25 Jun 2012 23:50:49 +0800,
Shawn Guo <shawn.guo@linaro.org> a ?crit :

> then, pinctrl system will be able to report there are 2 pin groups for
> function "duart" in debugfs.

Ah nice, this explains why the mxs pinctrl driver creates a separate
group for each pinctrl DT subnode, but only creates a new function when
the name changes.

However, how would the mxs pinctrl driver handle the following case:

	pinctrl {
		duart_pins_a: duart at 0 {
			...
		}
		something_pins: something at 0 {
			...
		}
		duart_pins_b: duart at 1 {
			...
		}
	}

Reading the driver code, I have the feeling that the logic that creates
the functions will only work if the different groups for a given
function are given as consecutive subnodes in the DT. Is this correct?

Regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2012-06-26  9:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-22  9:14 [PATCH v2] ARM:MXS: Initial support for the Crystalfontz CFA-10036 Maxime Ripard
2012-06-22  9:14 ` [PATCH 1/2] ARM:MX28: Add additionnal muxing options to iMX28 DTSI Maxime Ripard
2012-06-25 15:50   ` Shawn Guo
2012-06-26  9:02     ` Thomas Petazzoni [this message]
2012-06-26 11:33       ` Shawn Guo
2012-06-26  9:42     ` Maxime Ripard
2012-06-26 12:03       ` Shawn Guo
2012-06-22  9:14 ` [PATCH 2/2] ARM: MXS: Add Crystalfontz CFA-10036 DTS Maxime Ripard
2012-06-25 15:58   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120626110202.06807982@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).