linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: omap: remove unused cpu detection macros
Date: Wed, 27 Jun 2012 06:10:02 -0700	[thread overview]
Message-ID: <20120627131002.GH3483@atomide.com> (raw)
In-Reply-To: <1340745209.1911.15.camel@x61.thuisdomein>

* Paul Bolle <pebolle@tiscali.nl> [120626 14:18]:
> Now that OMAP730 and OMAP850 support is mostly unified, there's no
> need for separate cpu detection macros for these architectures. At
> least, currently there isn't, because both macros are unused.
> cpu_is_7xx() seems to cover all possible uses.
> 
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> 0) Entirely untested!

Seems to work :)
 
> 1) And now the IS_OMAP_TYPE() macro "calls" for 730 and 850 are unused.
> Not sure whether they should be removed too.

Yes those can go now too, I've applied the updated patch
below into fixes-non-critical along with the first patch
in this series.
 
> 2) Note that cpu_is_omap343x(), cpu_is_omap447x(), and cpu_is_omap2423()
> are all unused too. Reserved for future use, I guess.

It seems that at least 447x will be used soon. The others
we should be able to remove.

Regards,

Tony
 

Author: Paul Bolle <pebolle@tiscali.nl>
Date:   Tue Jun 26 23:13:29 2012 +0200

    ARM: OMAP: remove unused cpu detection macros
    
    Now that OMAP730 and OMAP850 support is mostly unified, there's no
    need for separate cpu detection macros for these architectures. At
    least, currently there isn't, because both macros are unused.
    cpu_is_7xx() seems to cover all possible uses.
    
    Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
    [tony at atomide.com: updated to also to remove related IS_OMAP_TYPE]
    Signed-off-by: Tony Lindgren <tony@atomide.com>

diff --git a/arch/arm/plat-omap/include/plat/cpu.h b/arch/arm/plat-omap/include/plat/cpu.h
index f2bdf15..e79e913 100644
--- a/arch/arm/plat-omap/include/plat/cpu.h
+++ b/arch/arm/plat-omap/include/plat/cpu.h
@@ -239,8 +239,6 @@ IS_AM_SUBCLASS(335x, 0x335)
  * Macros to detect individual cpu types.
  * These are only rarely needed.
  * cpu_is_omap310():	True for OMAP310
- * cpu_is_omap730():	True for OMAP730
- * cpu_is_omap850():	True for OMAP850
  * cpu_is_omap1510():	True for OMAP1510
  * cpu_is_omap1610():	True for OMAP1610
  * cpu_is_omap1611():	True for OMAP1611
@@ -264,8 +262,6 @@ static inline int is_omap ##type (void)			\
 }
 
 IS_OMAP_TYPE(310, 0x0310)
-IS_OMAP_TYPE(730, 0x0730)
-IS_OMAP_TYPE(850, 0x0850)
 IS_OMAP_TYPE(1510, 0x1510)
 IS_OMAP_TYPE(1610, 0x1610)
 IS_OMAP_TYPE(1611, 0x1611)
@@ -281,8 +277,6 @@ IS_OMAP_TYPE(3505, 0x3517)
 IS_OMAP_TYPE(3517, 0x3517)
 
 #define cpu_is_omap310()		0
-#define cpu_is_omap730()		0
-#define cpu_is_omap850()		0
 #define cpu_is_omap1510()		0
 #define cpu_is_omap1610()		0
 #define cpu_is_omap5912()		0
@@ -304,19 +298,9 @@ IS_OMAP_TYPE(3517, 0x3517)
 
 /*
  * Whether we have MULTI_OMAP1 or not, we still need to distinguish
- * between 730 vs 850, 310 vs. 1510 and 1611B/5912 vs. 1710.
+ * between 310 vs. 1510 and 1611B/5912 vs. 1710.
  */
 
-#if defined(CONFIG_ARCH_OMAP730)
-# undef  cpu_is_omap730
-# define cpu_is_omap730()		is_omap730()
-#endif
-
-#if defined(CONFIG_ARCH_OMAP850)
-# undef  cpu_is_omap850
-# define cpu_is_omap850()		is_omap850()
-#endif
-
 #if defined(CONFIG_ARCH_OMAP15XX)
 # undef  cpu_is_omap310
 # undef  cpu_is_omap1510

      reply	other threads:[~2012-06-27 13:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-26 21:13 [PATCH 2/2] ARM: omap: remove unused cpu detection macros Paul Bolle
2012-06-27 13:10 ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120627131002.GH3483@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).