From: aisheng.dong@freescale.com (Dong Aisheng)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] net: flexcan: add transceiver switch gpios support
Date: Thu, 28 Jun 2012 20:11:26 +0800 [thread overview]
Message-ID: <20120628121125.GN6406@shlinux2.ap.freescale.net> (raw)
In-Reply-To: <20120628120522.GH22990@S2101-09.ap.freescale.net>
On Thu, Jun 28, 2012 at 08:05:24PM +0800, Shawn Guo wrote:
> On Thu, Jun 28, 2012 at 07:52:26PM +0800, Shawn Guo wrote:
> > Do you care the variable name also? If so, we will get:
> >
> > int transceiver_en_gpio;
> > int transceiver_stby_gpio;
> > bool transceiver_en_high;
> > bool transceiver_stby_high;
> >
> > So everything becomes long :)
> >
> Oh, even longer, since we have agreed "high" should be renamed to
> "active_low":
>
> bool transceiver_en_active_low;
> bool transceiver_stby_active_low;
>
How about just active_low since they're just temp variables?
And if you do not assign them together at last, you may only need:
int gpio;
bool active_high;
That saves you two variables.
Regards
Dong Aisheng
next prev parent reply other threads:[~2012-06-28 12:11 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-28 3:21 [PATCH v2 0/2] flexcan driver updates Shawn Guo
2012-06-28 3:21 ` [PATCH v2 1/2] net: flexcan: clock-frequency is optional for device tree probe Shawn Guo
2012-06-28 11:23 ` Dong Aisheng
2012-06-28 3:21 ` [PATCH v2 2/2] net: flexcan: add transceiver switch gpios support Shawn Guo
2012-06-28 5:22 ` Lothar Waßmann
2012-06-28 5:30 ` Shawn Guo
2012-06-28 6:14 ` Hui Wang
2012-06-28 6:34 ` Shawn Guo
2012-06-28 7:01 ` Hui Wang
2012-06-28 10:32 ` Marc Kleine-Budde
2012-06-28 10:31 ` Marc Kleine-Budde
2012-06-28 11:21 ` Shawn Guo
2012-06-28 11:29 ` Marc Kleine-Budde
2012-06-28 11:41 ` Shawn Guo
2012-06-28 11:52 ` Shawn Guo
2012-06-28 12:05 ` Shawn Guo
2012-06-28 12:11 ` Dong Aisheng [this message]
2012-06-28 12:19 ` Lothar Waßmann
2012-06-28 12:07 ` Lothar Waßmann
2012-06-28 12:13 ` Shawn Guo
2012-06-28 12:24 ` Lothar Waßmann
2012-07-02 2:55 ` Hui Wang
2012-06-28 12:08 ` Kurt Van Dijck
2012-06-28 12:10 ` Marc Kleine-Budde
2012-06-28 12:16 ` Shawn Guo
2012-06-28 11:39 ` Dong Aisheng
2012-06-28 11:33 ` Dong Aisheng
2012-06-28 11:46 ` Shawn Guo
2012-06-28 11:48 ` Dong Aisheng
2012-06-28 12:00 ` Shawn Guo
2012-06-28 12:02 ` Dong Aisheng
2012-06-28 12:19 ` Shawn Guo
2012-06-28 12:05 ` Marc Kleine-Budde
2012-06-28 12:18 ` Dong Aisheng
2012-06-28 12:32 ` Lothar Waßmann
2012-06-28 12:40 ` Shawn Guo
2012-06-28 12:47 ` Dong Aisheng
2012-06-28 12:39 ` Shawn Guo
2012-06-29 9:27 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120628121125.GN6406@shlinux2.ap.freescale.net \
--to=aisheng.dong@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).