linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: OMAP2+: do not allow SmartReflex to be built as a module
@ 2012-06-28 16:55 Kevin Hilman
  2012-06-29 13:05 ` Tony Lindgren
  0 siblings, 1 reply; 2+ messages in thread
From: Kevin Hilman @ 2012-06-28 16:55 UTC (permalink / raw)
  To: linux-arm-kernel

From: Jean Pihet <j-pihet@ti.com>

Disable the module option for POWER_AVS since this is currently not
supported.

This patch fixes these error in the case POWER_AVS is set to 'm':

arch/arm/mach-omap2/built-in.o: In function `sr_class3_configure':
/home/tmlind/src/linux-2.6/arch/arm/mach-omap2/smartreflex-class3.c:43: undefined reference to `sr_configure_errgen'
arch/arm/mach-omap2/built-in.o: In function `sr_class3_disable':
/home/tmlind/src/linux-2.6/arch/arm/mach-omap2/smartreflex-class3.c:33: undefined reference to `sr_disable_errgen'
/home/tmlind/src/linux-2.6/arch/arm/mach-omap2/smartreflex-class3.c:35: undefined reference to `sr_disable'
arch/arm/mach-omap2/built-in.o: In function `sr_class3_enable':
/home/tmlind/src/linux-2.6/arch/arm/mach-omap2/smartreflex-class3.c:28: undefined reference to `sr_enable'
arch/arm/mach-omap2/built-in.o: In function `sr_class3_init':
/home/tmlind/src/linux-2.6/arch/arm/mach-omap2/smartreflex-class3.c:59: undefined reference to `sr_register_class'

Reported-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Jean Pihet <j-pihet@ti.com>
Signed-off-by: Kevin Hilman <khilman@ti.com>
---
Tony, this one fixes the SR related build errors you saw with
randconfig.  It applies to my for_3.6/pm/sr-move branch which is now
included in your devel-driver.  Let me know if want me to fold this
into the original and re-spin the branch.

Also, special thanks to Jean for fixing this immediatly after it 
was reported!

 drivers/power/avs/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/power/avs/Kconfig b/drivers/power/avs/Kconfig
index 18493f7..2a1008b 100644
--- a/drivers/power/avs/Kconfig
+++ b/drivers/power/avs/Kconfig
@@ -1,5 +1,5 @@
 menuconfig POWER_AVS
-	tristate "Adaptive Voltage Scaling class support"
+	bool "Adaptive Voltage Scaling class support"
 	help
 	  AVS is a power management technique which finely controls the
 	  operating voltage of a device in order to optimize (i.e. reduce)
-- 
1.7.9.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] ARM: OMAP2+: do not allow SmartReflex to be built as a module
  2012-06-28 16:55 [PATCH] ARM: OMAP2+: do not allow SmartReflex to be built as a module Kevin Hilman
@ 2012-06-29 13:05 ` Tony Lindgren
  0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2012-06-29 13:05 UTC (permalink / raw)
  To: linux-arm-kernel

* Kevin Hilman <khilman@ti.com> [120628 10:00]:
> From: Jean Pihet <j-pihet@ti.com>
> 
> Disable the module option for POWER_AVS since this is currently not
> supported.
> 
> This patch fixes these error in the case POWER_AVS is set to 'm':
> 
> arch/arm/mach-omap2/built-in.o: In function `sr_class3_configure':
> /home/tmlind/src/linux-2.6/arch/arm/mach-omap2/smartreflex-class3.c:43: undefined reference to `sr_configure_errgen'
> arch/arm/mach-omap2/built-in.o: In function `sr_class3_disable':
> /home/tmlind/src/linux-2.6/arch/arm/mach-omap2/smartreflex-class3.c:33: undefined reference to `sr_disable_errgen'
> /home/tmlind/src/linux-2.6/arch/arm/mach-omap2/smartreflex-class3.c:35: undefined reference to `sr_disable'
> arch/arm/mach-omap2/built-in.o: In function `sr_class3_enable':
> /home/tmlind/src/linux-2.6/arch/arm/mach-omap2/smartreflex-class3.c:28: undefined reference to `sr_enable'
> arch/arm/mach-omap2/built-in.o: In function `sr_class3_init':
> /home/tmlind/src/linux-2.6/arch/arm/mach-omap2/smartreflex-class3.c:59: undefined reference to `sr_register_class'
> 
> Reported-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Jean Pihet <j-pihet@ti.com>
> Signed-off-by: Kevin Hilman <khilman@ti.com>
> ---
> Tony, this one fixes the SR related build errors you saw with
> randconfig.  It applies to my for_3.6/pm/sr-move branch which is now
> included in your devel-driver.  Let me know if want me to fold this
> into the original and re-spin the branch.
> 
> Also, special thanks to Jean for fixing this immediatly after it 
> was reported!

Thanks applying into devel-driver branch.

Tony

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-06-29 13:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-28 16:55 [PATCH] ARM: OMAP2+: do not allow SmartReflex to be built as a module Kevin Hilman
2012-06-29 13:05 ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).