From: rubini@gnudd.com (Alessandro Rubini)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 5/6] x86: add CONFIG_ARM_AMBA, selected by STA2X11
Date: Sun, 1 Jul 2012 12:44:01 +0200 [thread overview]
Message-ID: <20120701104401.GA4352@mail.gnudd.com> (raw)
In-Reply-To: <4FECB95D.7010200@zytor.com>
>> The sta2x11 I/O Hub is a bridge from PCIe to AMBA. It reuses a number
>> of amba drivers and needs to activate core bus support.
> Nacked-by: H. Peter Anvin <hpa@zytor.com>
>
> This brings in tons of code into the x86 all{yes,mod}config builds, and
> as perhaps one could expect some of it doesn't compile. For example:
Ok. I apologize for not checking this. Actually, I only fixed the ones
that I needed to compile.
How should I address the problem? (original code, published on
sourceforge was simply replicating a number of amba drivers into pci
drivers, but I don't think massive code duplication is ever sensible,
thus I preferred to reuse the existing drivers).
I doubt all amba drivers can easily be made x86-compatible.
I see these possible approaces, all of them with their cons
1- add STA2X11 dependencies to ARM_AMBA _and_ the drivers that do work
2- leave CONFIG_ARM_AMBA undefined and play select file in Makefiles
using obj-$(CONFIG_STA2X11)
3- add ARM dependencies to the drivers that do not compile on x86
any other option?
(1) and (2) bring chipset-specific stuff into the amba world, which is
bad, especially since I suspect other similar bridges will appear soon.
(3) looks like a temporary hack and stuff can be fixed over time, but
it has the disadvantage of adding a big number of needless drivers in
the dsitributions' packages -- like my nacked patch did.
thanks
/alessandro
next prev parent reply other threads:[~2012-07-01 10:44 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1338222460.git.rubini@gnudd.com>
2012-05-28 16:37 ` [PATCH V2 1/6] sizes.h: move from asm-generic to <linux/sizes.h> Alessandro Rubini
2012-05-28 16:37 ` [PATCH V2 2/6] amba: use the new linux/sizes.h Alessandro Rubini
2012-05-28 16:37 ` [PATCH V2 3/6] ARM: " Alessandro Rubini
2012-05-28 16:37 ` [PATCH V2 4/6] serial: " Alessandro Rubini
2012-05-28 16:37 ` [PATCH V2 5/6] x86: add CONFIG_ARM_AMBA, selected by STA2X11 Alessandro Rubini
2012-06-28 20:06 ` H. Peter Anvin
2012-07-01 10:44 ` Alessandro Rubini [this message]
2012-07-01 10:59 ` Russell King - ARM Linux
2012-07-01 11:58 ` Jassi Brar
2012-07-01 12:10 ` Russell King - ARM Linux
2012-07-01 13:11 ` Jassi Brar
2012-07-01 11:04 ` Alessandro Rubini
2012-07-01 11:11 ` Russell King - ARM Linux
2012-07-01 14:13 ` H. Peter Anvin
2012-07-02 16:58 ` Arnd Bergmann
2012-07-02 18:05 ` Mark Brown
2012-07-02 18:07 ` H. Peter Anvin
2012-07-02 18:33 ` Mark Brown
2012-07-02 19:41 ` H. Peter Anvin
2012-07-03 11:05 ` Mark Brown
2012-07-03 13:00 ` Alessandro Rubini
2012-07-03 13:19 ` Arnd Bergmann
2012-07-03 19:34 ` Russell King - ARM Linux
2012-08-05 20:28 ` Linus Walleij
2012-08-07 10:06 ` Kukjin Kim
2012-07-03 13:26 ` Alessandro Rubini
2012-07-03 19:46 ` Russell King - ARM Linux
2012-05-28 16:38 ` [PATCH V2 6/6] drivers/amba: add support for a PCI bridge Alessandro Rubini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120701104401.GA4352@mail.gnudd.com \
--to=rubini@gnudd.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).