From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3 17/17] i2c: omap: get rid of the "complete" label
Date: Mon, 2 Jul 2012 14:59:05 +0300 [thread overview]
Message-ID: <20120702115904.GE2730@arwen.pp.htv.fi> (raw)
In-Reply-To: <1340964817-8599-18-git-send-email-shubhrajyoti@ti.com>
Hi,
On Fri, Jun 29, 2012 at 03:43:37PM +0530, Shubhrajyoti D wrote:
> @@ -962,7 +972,7 @@ complete:
> ret = omap_i2c_transmit_data(dev, num_bytes, true);
> stat = omap_i2c_read_reg(dev, OMAP_I2C_STAT_REG);
this isn't needed anymore. please remove.
> if (ret < 0)
> - goto complete;
> + goto out;
>
> omap_i2c_ack_stat(dev, OMAP_I2C_STAT_XDR);
> continue;
> @@ -978,7 +988,7 @@ complete:
> ret = omap_i2c_transmit_data(dev, num_bytes, false);
> stat = omap_i2c_read_reg(dev, OMAP_I2C_STAT_REG);
this isn't needed anymore. please remove.
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120702/5cae2edd/attachment.sig>
prev parent reply other threads:[~2012-07-02 11:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-29 10:13 [PATCHv3 00/17] I2C Big cleanup Shubhrajyoti D
2012-06-29 10:13 ` [PATCHv3 01/17] i2c: omap: switch to devm_* API Shubhrajyoti D
2012-06-29 10:13 ` [PATCHv3 02/17] i2c: omap: simplify num_bytes handling Shubhrajyoti D
2012-06-29 10:13 ` [PATCHv3 03/17] i2c: omap: decrease indentation level on data handling Shubhrajyoti D
2012-06-29 10:13 ` [PATCHv3 04/17] i2c: omap: add blank lines Shubhrajyoti D
2012-06-29 10:13 ` [PATCHv3 05/17] i2c: omap: simplify omap_i2c_ack_stat() Shubhrajyoti D
2012-06-29 10:13 ` [PATCHv3 06/17] i2c: omap: split out [XR]DR and [XR]RDY Shubhrajyoti D
2012-07-02 11:56 ` Felipe Balbi
2012-07-02 12:00 ` Shubhrajyoti Datta
2012-06-29 10:13 ` [PATCHv3 07/17] i2c: omap: improve i462 errata handling Shubhrajyoti D
2012-06-29 10:13 ` [PATCHv3 08/17] i2c: omap: re-factor receive/transmit data loop Shubhrajyoti D
2012-06-29 10:13 ` [PATCHv3 09/17] i2c: omap: switch over to do {} while loop Shubhrajyoti D
2012-06-29 10:13 ` [PATCHv3 10/17] i2c: omap: ack IRQ in parts Shubhrajyoti D
2012-06-29 10:13 ` [PATCHv3 11/17] i2c: omap: switch to platform_get_irq() Shubhrajyoti D
2012-06-29 10:13 ` [PATCHv3 12/17] i2c: omap: bus: add a receiver flag Shubhrajyoti D
2012-06-29 10:13 ` [PATCHv3 13/17] i2c: omap: simplify errata check Shubhrajyoti D
2012-06-29 10:13 ` [PATCHv3 14/17] i2c: omap: always return IRQ_HANDLED Shubhrajyoti D
2012-06-29 10:13 ` [PATCHv3 15/17] i2c: omap: simplify IRQ exit path Shubhrajyoti D
2012-06-29 10:13 ` [PATCHv3 16/17] i2c: omap: resize fifos before each message Shubhrajyoti D
2012-06-29 10:13 ` [PATCHv3 17/17] i2c: omap: get rid of the "complete" label Shubhrajyoti D
2012-07-02 11:59 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120702115904.GE2730@arwen.pp.htv.fi \
--to=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox