From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 4/9] arm: mach-mvebu: add support for Armada 370 and Armada XP with DT
Date: Mon, 2 Jul 2012 13:37:03 +0200 [thread overview]
Message-ID: <20120702133703.7c693ed3@skate> (raw)
In-Reply-To: <4FEB30A7.3000809@codethink.co.uk>
Le Wed, 27 Jun 2012 17:11:19 +0100,
Ben Dooks <ben.dooks@codethink.co.uk> a ?crit :
> > diff --git a/arch/arm/mach-mvebu/common.h b/arch/arm/mach-mvebu/common.h
> > index f0eaa21..1b1e679 100644
> > --- a/arch/arm/mach-mvebu/common.h
> > +++ b/arch/arm/mach-mvebu/common.h
> > @@ -17,4 +17,7 @@
> >
> > void mvebu_restart(char mode, const char *cmd);
>
> If you set it when you probed the device, you'd not need
> to export it in the header.
As per the discussion with Russell King on your patch 3/3 about the
restart() hook, we had to keep this function prototype as it is.
> > +void armada_370_xp_init_irq(void);
> > +asmlinkage void armada_370_xp_handle_irq(struct pt_regs *regs);
>
> You shouldn't need linkage info with a function declaration.
Good point, fixed!
Thanks,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-07-02 11:37 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 13:54 [PATCH v5] arm: Add basic support for new Marvell Armada 370 and Armada XP SoC Gregory Clement
2012-06-27 13:54 ` [PATCH v5 1/9] clocksource: time-armada-370-xp: Marvell Armada 370/XP SoC timer driver Gregory Clement
2012-06-27 13:54 ` [PATCH v5 2/9] arm: mach-mvebu: add header Gregory Clement
2012-06-27 13:54 ` [PATCH v5 3/9] arm: mach-mvebu: add source files Gregory Clement
2012-06-27 15:36 ` Andrew Lunn
2012-06-28 18:07 ` Nicolas Pitre
2012-07-02 11:36 ` Thomas Petazzoni
2012-06-27 13:54 ` [PATCH v5 4/9] arm: mach-mvebu: add support for Armada 370 and Armada XP with DT Gregory Clement
2012-06-27 16:11 ` Ben Dooks
2012-07-02 11:37 ` Thomas Petazzoni [this message]
2012-06-27 13:54 ` [PATCH v5 5/9] arm: mach-mvebu: add documentation for new device tree bindings Gregory Clement
2012-06-27 13:54 ` [PATCH v5 6/9] arm: mach-mvebu: add defconfig Gregory Clement
2012-06-27 13:54 ` [PATCH v5 7/9] arm: mach-mvebu: add compilation/configuration change Gregory Clement
2012-06-27 13:54 ` [PATCH v5 8/9] arm: mach-mvebu: add entry to MAINTAINERS Gregory Clement
2012-06-27 13:54 ` [PATCH v5 9/9] ARM: mvebu: MPIC: read number of interrupts from control register Gregory Clement
2012-06-27 15:54 ` [PATCH v5] arm: Add basic support for new Marvell Armada 370 and Armada XP SoC Ben Dooks
2012-07-02 8:30 ` Thomas Petazzoni
2012-07-02 9:19 ` Ben Dooks
2012-07-02 9:19 ` Thomas Petazzoni
2012-07-02 9:25 ` Ben Dooks
2012-07-02 9:26 ` Thomas Petazzoni
2012-06-27 16:26 ` review comments Ben Dooks
2012-06-27 16:26 ` [PATCH 1/3] arm: mach-mvebu: fixup style error in system-controller Ben Dooks
2012-06-27 16:26 ` [PATCH 2/3] arm: mach-mvebu: check result of of_match_node() Ben Dooks
2012-06-27 16:26 ` [PATCH 3/3] arm: mach-mvebu: system-controller only registers restart if device exists Ben Dooks
2012-06-27 19:19 ` Russell King - ARM Linux
2012-06-28 9:23 ` Ben Dooks
2012-06-28 10:17 ` Russell King - ARM Linux
2012-07-02 11:35 ` review comments Thomas Petazzoni
2012-06-28 12:10 ` [PATCH v5] arm: Add basic support for new Marvell Armada 370 and Armada XP SoC Lior Amsalem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120702133703.7c693ed3@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).