linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: imx6q-sabrelite.dts: Add watchdog support
Date: Tue, 3 Jul 2012 12:17:44 +0200	[thread overview]
Message-ID: <20120703101744.GW2698@pengutronix.de> (raw)
In-Reply-To: <20120703030337.GD22106@S2101-09.ap.freescale.net>

On Tue, Jul 03, 2012 at 11:03:39AM +0800, Shawn Guo wrote:
> On Mon, Jul 02, 2012 at 04:50:26PM -0300, Fabio Estevam wrote:
> > From: Fabio Estevam <fabio.estevam@freescale.com>
> > 
> > Add watchdog support.
> > 
> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> > ---
> >  arch/arm/boot/dts/imx6q-sabrelite.dts |    3 +++
> >  1 files changed, 3 insertions(+), 0 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/imx6q-sabrelite.dts b/arch/arm/boot/dts/imx6q-sabrelite.dts
> > index e0ec929..99581a0 100644
> > --- a/arch/arm/boot/dts/imx6q-sabrelite.dts
> > +++ b/arch/arm/boot/dts/imx6q-sabrelite.dts
> > @@ -42,6 +42,9 @@
> >  				};
> >  			};
> >  
> > +			wdog at 020bc000 { /* WDOG1 */
> > +				status = "okay";
> > +			};
> 
> I'm wondering if it makes more sense to have wdog, rtc, such completely
> soc internal stuff always enabled in <soc>.dtsi.

+1 for the watchdog

I'm not so sure about the rtc though, since one important component of
the RTC is not completely internal to the SoC: the battery.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2012-07-03 10:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-02 19:50 [PATCH 1/2] ARM: imx6q-sabrelite.dts: Add watchdog support Fabio Estevam
2012-07-02 19:50 ` [PATCH 2/2] ARM: imx6q-sabresd.dts: " Fabio Estevam
2012-07-03  3:03 ` [PATCH 1/2] ARM: imx6q-sabrelite.dts: " Shawn Guo
2012-07-03 10:17   ` Sascha Hauer [this message]
2012-07-03 10:39     ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120703101744.GW2698@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).