From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: imx: assert SCC gate stays enabled
Date: Wed, 4 Jul 2012 09:02:42 +0200 [thread overview]
Message-ID: <20120704070242.GH2698@pengutronix.de> (raw)
In-Reply-To: <1341221434-15233-1-git-send-email-u.kleine-koenig@pengutronix.de>
On Mon, Jul 02, 2012 at 11:30:34AM +0200, Uwe Kleine-K?nig wrote:
> The SCC clock is needed in internal boot mode and so must keep enabled.
> This same issue was fixed for the pre-common-clk code in commit
Applied as fix.
Sascha
>
> 3d6e614 (mx35: Fix boot ROM hang in internal boot mode)
>
> Cc: John Ogness <jogness@linutronix.de>
> Cc: Hans J. Koch <hjk@hansjkoch.de>
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> ---
> arch/arm/mach-imx/clk-imx35.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-imx/clk-imx35.c b/arch/arm/mach-imx/clk-imx35.c
> index 920a8cc..c6422fb 100644
> --- a/arch/arm/mach-imx/clk-imx35.c
> +++ b/arch/arm/mach-imx/clk-imx35.c
> @@ -201,7 +201,6 @@ int __init mx35_clocks_init()
> pr_err("i.MX35 clk %d: register failed with %ld\n",
> i, PTR_ERR(clk[i]));
>
> -
> clk_register_clkdev(clk[pata_gate], NULL, "pata_imx");
> clk_register_clkdev(clk[can1_gate], NULL, "flexcan.0");
> clk_register_clkdev(clk[can2_gate], NULL, "flexcan.1");
> @@ -264,6 +263,14 @@ int __init mx35_clocks_init()
> clk_prepare_enable(clk[iim_gate]);
> clk_prepare_enable(clk[emi_gate]);
>
> + /*
> + * SCC is needed to boot via mmc after a watchdog reset. The clock code
> + * before conversion to common clk also enabled UART1 (which isn't
> + * handled here and not needed for mmc) and IIM (which is enabled
> + * unconditionally above).
> + */
> + clk_prepare_enable(clk[scc_gate]);
> +
> imx_print_silicon_rev("i.MX35", mx35_revision());
>
> #ifdef CONFIG_MXC_USE_EPIT
> --
> 1.7.10
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2012-07-04 7:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 9:30 [PATCH] ARM: imx: assert SCC gate stays enabled Uwe Kleine-König
2012-07-04 7:02 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120704070242.GH2698@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).