From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: How to handle parameter variation across different boards but same platform
Date: Wed, 4 Jul 2012 15:27:45 +0100 [thread overview]
Message-ID: <20120704142745.GC4111@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1BAFE6F6C881BF42822005164F1491C33EA35B10@DBDE01.ent.ti.com>
On Wed, Jul 04, 2012 at 02:17:48PM +0000, Hebbar, Gururaja wrote:
> On Wed, Jul 04, 2012 at 19:31:18, Mark Brown wrote:
> > If these are totally different boards they should have different machine
> > IDs set so machine_is_() should identify. If that isn't there then you
> > need to do something custom to your products to identify the boards
> > further.
> They are different boards with same SoC (AM33xx). So they both are true for
> machine_is_am33xx().
That's not how this stuff is supposed to work - machine is the board,
you should have cpu_is_() for identifying the SoC.
> We have a means to detect the type of board but in arch/arm/mach-omap2/
> board file. However, I believe it is not recommended to call boards api
> inside drivers.
Only for generic drivers, board specific drivers are obviously board
specific. The point is that you shouldn't make something that could run
on many boards depend on an API specific to a particular board.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120704/1c0b65e9/attachment-0001.sig>
next prev parent reply other threads:[~2012-07-04 14:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-04 12:45 How to handle parameter variation across different boards but same platform Hebbar, Gururaja
2012-07-04 13:17 ` Mark Brown
2012-07-04 13:43 ` Hebbar, Gururaja
2012-07-04 14:01 ` Mark Brown
2012-07-04 14:17 ` Hebbar, Gururaja
2012-07-04 14:27 ` Mark Brown [this message]
2012-07-05 5:42 ` Vaibhav Hiremath
2012-07-05 8:32 ` Arnd Bergmann
2012-07-05 9:38 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120704142745.GC4111@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).