From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: mxs: imx28: decrease the frequency of ref_io1 for SSP2 and SSP3
Date: Wed, 4 Jul 2012 18:23:27 +0200 [thread overview]
Message-ID: <201207041823.27336.marex@denx.de> (raw)
In-Reply-To: <20120704133554.GB2595@S2101-09.ap.freescale.net>
Dear Shawn Guo,
> On Wed, Jul 04, 2012 at 01:49:54PM +0300, Lauri Hintsala wrote:
> > SSP0 and SSP1 use ref_io0 which has decreased frequency. Expand
> > the frequency fix for ref_io1 to get SSP2 and SSP3 to work.
>
> The patch looks okay. Just to confirm that you are running SSP2&SSP3
> into the same frequency problem that we had with SSP0&SSP1? I never
> got a board to verify that for SSP2&SSP3.
What problem is that? I've been running the SPI driver against two types of SPI
flashes on SSP2 without trouble ...
> Regards,
> Shawn
>
> > Signed-off-by: Lauri Hintsala <lauri.hintsala@bluegiga.com>
> > ---
> >
> > drivers/clk/mxs/clk-imx28.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/clk/mxs/clk-imx28.c b/drivers/clk/mxs/clk-imx28.c
> > index 2826a26..0097c3a 100644
> > --- a/drivers/clk/mxs/clk-imx28.c
> > +++ b/drivers/clk/mxs/clk-imx28.c
> > @@ -112,11 +112,11 @@ static void __init clk_misc_init(void)
> >
> > /*
> >
> > * 480 MHz seems too high to be ssp clock source directly,
> >
> > - * so set frac0 to get a 288 MHz ref_io0.
> > + * so set frac0 to get a 288 MHz ref_io0 and ref_io1.
> >
> > */
> >
> > val = readl_relaxed(FRAC0);
> >
> > - val &= ~(0x3f << BP_FRAC0_IO0FRAC);
> > - val |= 30 << BP_FRAC0_IO0FRAC;
> > + val &= ~((0x3f << BP_FRAC0_IO0FRAC) | (0x3f << BP_FRAC0_IO1FRAC));
> > + val |= (30 << BP_FRAC0_IO0FRAC) | (30 << BP_FRAC0_IO1FRAC);
> >
> > writel_relaxed(val, FRAC0);
> >
> > }
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-07-04 16:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-04 10:49 [PATCH] clk: mxs: imx28: decrease the frequency of ref_io1 for SSP2 and SSP3 Lauri Hintsala
2012-07-04 13:35 ` Shawn Guo
2012-07-04 14:02 ` Lauri Hintsala
2012-07-04 16:23 ` Marek Vasut [this message]
2012-07-04 16:39 ` Fabio Estevam
2012-07-05 3:06 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201207041823.27336.marex@denx.de \
--to=marex@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).