From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 8/8] mmc: spi: Add DMA support into SPI driver
Date: Wed, 4 Jul 2012 23:40:55 +0200 [thread overview]
Message-ID: <201207042340.55301.marex@denx.de> (raw)
In-Reply-To: <CAOMZO5AN852f3Awv0UG+ApsgMC-x5ByQrLkUC5SkOnty5T0EMA@mail.gmail.com>
Dear Fabio Estevam,
> Hi Marek,
>
> On 6/29/12, Marek Vasut <marex@denx.de> wrote:
> > iores = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> >
> > - if (!iores)
> > + dmares = platform_get_resource(pdev, IORESOURCE_DMA, 0);
> > + irq_err = platform_get_irq(pdev, 0);
> > + irq_dma = platform_get_irq(pdev, 1);
> > + if (!iores || irq_err < 0 || irq_dma < 0)
>
> Shouldn't you check for dmares < 0 here too?
Yes. What about the rest of the patches? Are they applicable?
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-07-04 21:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-29 8:22 [PATCH 1/8] mmc: spi: Move SSP register definitions into separate file Marek Vasut
2012-06-29 8:22 ` [PATCH 2/8] mmc: spi: Rename IMX2[38]_MMC to IMX2[38]_SSP Marek Vasut
2012-06-29 8:22 ` [PATCH 3/8] mmc: spi: Add necessary bits into mxs-spi.h Marek Vasut
2012-06-29 8:22 ` [PATCH 4/8] mmc: spi: Pull out parts shared between MMC and SPI Marek Vasut
2012-06-29 8:22 ` [PATCH 5/8] mmc: spi: Pull out the SSP clock configuration function Marek Vasut
2012-06-29 8:22 ` [PATCH 6/8] mmc: spi: Add SPI driver for mx233/mx28 Marek Vasut
2012-07-05 0:51 ` Shawn Guo
2012-07-05 5:39 ` Marek Vasut
2012-07-05 5:43 ` Shawn Guo
2012-07-05 5:46 ` Marek Vasut
2012-07-05 5:51 ` Shawn Guo
2012-07-05 6:00 ` Marek Vasut
2012-06-29 8:22 ` [PATCH 7/8] mmc: spi: Pull out common DMA parts from MXS MMC Marek Vasut
2012-06-29 8:23 ` [PATCH 8/8] mmc: spi: Add DMA support into SPI driver Marek Vasut
2012-06-29 13:49 ` Fabio Estevam
2012-07-04 21:40 ` Marek Vasut [this message]
2012-07-04 21:43 ` Fabio Estevam
2012-07-04 23:20 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201207042340.55301.marex@denx.de \
--to=marex@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).