From mboxrd@z Thu Jan 1 00:00:00 1970 From: marex@denx.de (Marek Vasut) Date: Wed, 4 Jul 2012 23:40:55 +0200 Subject: [PATCH 8/8] mmc: spi: Add DMA support into SPI driver In-Reply-To: References: <1340958180-2291-1-git-send-email-marex@denx.de> <1340958180-2291-8-git-send-email-marex@denx.de> Message-ID: <201207042340.55301.marex@denx.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Dear Fabio Estevam, > Hi Marek, > > On 6/29/12, Marek Vasut wrote: > > iores = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > > > - if (!iores) > > + dmares = platform_get_resource(pdev, IORESOURCE_DMA, 0); > > + irq_err = platform_get_irq(pdev, 0); > > + irq_dma = platform_get_irq(pdev, 1); > > + if (!iores || irq_err < 0 || irq_dma < 0) > > Shouldn't you check for dmares < 0 here too? Yes. What about the rest of the patches? Are they applicable? Best regards, Marek Vasut