linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: MX28 poweroff issue
Date: Thu, 5 Jul 2012 18:23:26 +0200	[thread overview]
Message-ID: <201207051823.26243.marex@denx.de> (raw)
In-Reply-To: <20120705160855.GA20175@S2101-09.ap.freescale.net>

Dear Shawn Guo,

[...]

> diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
> index 19c95ea..e41edea 100644
> --- a/arch/arm/kernel/process.c
> +++ b/arch/arm/kernel/process.c
> @@ -247,7 +247,8 @@ void machine_shutdown(void)
>  void machine_halt(void)
>  {
>         machine_shutdown();
> -       while (1);
> +       while (1)
> +               msleep(1);

Won't mdelay() be better?

It removes the warning, but can't some other stray interrupt trigger it again?

>  }

Best regards,
Marek Vasut

  reply	other threads:[~2012-07-05 16:23 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-03 22:30 MX28 poweroff issue Marek Vasut
2012-07-03 22:46 ` Russell King - ARM Linux
2012-07-04  0:13   ` Marek Vasut
2012-07-04  1:10 ` Fabio Estevam
2012-07-04  2:12   ` Marek Vasut
2012-07-04  3:14     ` Fabio Estevam
2012-07-04  3:47       ` Marek Vasut
2012-07-04  7:07         ` Uwe Kleine-König
2012-07-04  8:20           ` Russell King - ARM Linux
2012-07-04  8:45             ` Uwe Kleine-König
2012-07-04 14:30               ` Marek Vasut
2012-07-04  7:38       ` Attila Kinali
2012-07-04 14:31         ` Marek Vasut
2012-07-04 14:53           ` Shawn Guo
2012-07-04 15:19           ` Russell King - ARM Linux
2012-07-05 16:08             ` Shawn Guo
2012-07-05 16:23               ` Marek Vasut [this message]
2012-07-05 20:32                 ` Fabio Estevam
2012-07-05 20:59                   ` Fabio Estevam
2012-07-05 20:10               ` Russell King - ARM Linux
2012-07-06  4:49                 ` Shawn Guo
2012-07-06  7:32                 ` Lothar Waßmann
2012-07-19 17:04                   ` Marek Vasut
2012-07-20  0:48                     ` Shawn Guo
2012-07-20  1:53                       ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201207051823.26243.marex@denx.de \
    --to=marex@denx.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).