linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/5] ARM: omap3evm: enable VBUS switch for EHCI tranceiver
Date: Fri, 6 Jul 2012 01:41:05 -0700	[thread overview]
Message-ID: <20120706084105.GR1122@atomide.com> (raw)
In-Reply-To: <4FE1BC98.7050607@mvista.com>

* Sergei Shtylyov <sshtylyov@mvista.com> [120620 05:10]:
> On 20-06-2012 13:14, Zumeng Chen wrote:
> >
> >This will set TWL4030.GPIO2 as output pin to drive EHCI tranceiver.
...

> >+	/* Enable VBUS switch by setting TWL4030.GPIO2DIR as output
> >+	 * for starting USB tranceiver
> >+	 */
> >+	if (get_omap3_evm_rev()>= OMAP3EVM_BOARD_GEN_2) {
> >+		u8 val;
> 
>    Empty line after declaration block wouldn't hurt...
> 

I'll apply these into devel-board branch with the extra line
added. Not taking the clock related patch 4/5 as that's something
Paul should queue.

Also note that the board-*.c files are being phased out with
devicetree support.

Regards,

Tony

  parent reply	other threads:[~2012-07-06  8:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-20  9:14 [PATCH v3 0/5] ARM OMAP3530evm misc fixes Zumeng Chen
2012-06-20  9:14 ` [PATCH 1/5] ARM: OMAP3EVM: Add NAND flash definition Zumeng Chen
2012-06-20  9:14 ` [PATCH 2/5] ARM: OMAP3EVM: Adding USB internal LDOs board file Zumeng Chen
2012-06-20  9:14 ` [PATCH 3/5] ARM: omap3evm: enable VBUS switch for EHCI tranceiver Zumeng Chen
2012-06-20 12:05   ` Sergei Shtylyov
2012-06-21  1:03     ` Zumeng Chen
2012-07-06  8:41     ` Tony Lindgren [this message]
2012-07-08  7:50       ` Zumeng Chen
2012-06-20  9:14 ` [PATCH 4/5] ARM: OMAP3EVM: cosmetic fixes for parent clk set Zumeng Chen
2012-06-20 16:00   ` Jon Hunter
2012-06-21  1:05     ` Zumeng Chen
2012-07-06  8:38   ` Tony Lindgren
2012-06-20  9:14 ` [PATCH 5/5] ARM: OMAP3530evm: set pendown_state and debounce time for ads7846 Zumeng Chen
  -- strict thread matches above, loose matches on Subject: below --
2012-06-11 14:00 [PATCH 0/5] OMAP3530evm misc fixes for linux-omap Zumeng Chen
2012-06-11 14:00 ` [PATCH 3/5] ARM: omap3evm: enable VBUS switch for EHCI tranceiver Zumeng Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120706084105.GR1122@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).