linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: b29396@freescale.com (Dong Aisheng)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: mxs: Export missing symbols from mxs-dma.c
Date: Fri, 6 Jul 2012 18:52:53 +0800	[thread overview]
Message-ID: <20120706105252.GC12558@shlinux2.ap.freescale.net> (raw)
In-Reply-To: <1341565366-11441-1-git-send-email-attila@kinali.ch>

On Fri, Jul 06, 2012 at 11:02:46AM +0200, Attila Kinali wrote:
> mxs-dma.c provides two functions mxs_dma_is_apbh and mxs_dma_is_apbx
> which are used at least in mxs-mmc.c. Building mxs-mmc as module
> fails due to those two symbols not being exported.
> 
> Signed-off-by: Attila Kinali <attila@kinali.ch>
> ---
>  drivers/dma/mxs-dma.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/dma/mxs-dma.c b/drivers/dma/mxs-dma.c
> index c96ab15..4ea1909 100644
> --- a/drivers/dma/mxs-dma.c
> +++ b/drivers/dma/mxs-dma.c
> @@ -779,3 +779,6 @@ static int __init mxs_dma_module_init(void)
>  	return platform_driver_probe(&mxs_dma_driver, mxs_dma_probe);
>  }
>  subsys_initcall(mxs_dma_module_init);
> +
> +EXPORT_SYMBOL(mxs_dma_is_apbh);
> +EXPORT_SYMBOL(mxs_dma_is_apbx);
If i understand correctly, usually we add EXPORT_SYMBOL right below the function
exported.
And can we use EXPORT_SYMBOL_GPL?
It seems both driver using this are gpl licensed.

BTW, maybe you also need change the patch title format a bit:
dma: mxs-dma: ...

Regards
Dong Aisheng

  reply	other threads:[~2012-07-06 10:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-06  9:02 [PATCH] ARM: mxs: Export missing symbols from mxs-dma.c Attila Kinali
2012-07-06 10:52 ` Dong Aisheng [this message]
2012-07-06 11:09   ` [PATCH] ARM: dma: mxs-dma: " Attila Kinali
2012-07-06 11:10     ` Dong Aisheng
2012-07-06 11:19       ` Attila Kinali
2012-07-06 11:22       ` Attila Kinali
2012-07-06 11:17         ` Dong Aisheng
2012-07-06 12:21         ` Shawn Guo
2012-07-06 12:53           ` [PATCH] " Attila Kinali
2012-07-06 13:45             ` Shawn Guo
2012-07-16  6:30             ` Vinod Koul
2012-07-16  9:19               ` Attila Kinali

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120706105252.GC12558@shlinux2.ap.freescale.net \
    --to=b29396@freescale.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).