From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP2+: omap2plus_defconfig: EHCI driver is not stable, disable it
Date: Mon, 9 Jul 2012 01:40:33 -0700 [thread overview]
Message-ID: <20120709084032.GZ1122@atomide.com> (raw)
In-Reply-To: <1341598828-31410-1-git-send-email-khilman@ti.com>
* Kevin Hilman <khilman@ti.com> [120706 11:25]:
> The EHCI driver is not stable enough to be enabled by default. In v3.5,
> it has at least the following problems:
>
> - warning dump during bootup
> - hang during suspend
> - prevents CORE powerdomain from entering retention during idle (even
> when no USB devices connected.)
>
> This demonstrates that this driver has not been thoroughly tested and
> therfore should not be enabled in the default defconfig.
>
> In addition, the problems above cause new PM regressions which need be
> addressed before this driver should be enabled in the default
> defconfig.
>
> Signed-off-by: Kevin Hilman <khilman@ti.com>
> ---
> Tony, this applies to your current fixes branch. Please queue up for v3.5-rc
> so this PM regression is fixed in v3.5. Thanks.
OK adding, although I don't like the idea of having to disable drivers
in the defconfig to fix issues :( The hang during suspend case would
be potentially hit by many people.. Should the driver/usb/host/ehci-omap.c
be patched to disable suspend or at least warn about it?
Regards,
Tony
> arch/arm/configs/omap2plus_defconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
> index 9854ff4..11828e6 100644
> --- a/arch/arm/configs/omap2plus_defconfig
> +++ b/arch/arm/configs/omap2plus_defconfig
> @@ -176,7 +176,6 @@ CONFIG_USB_ANNOUNCE_NEW_DEVICES=y
> CONFIG_USB_DEVICEFS=y
> CONFIG_USB_SUSPEND=y
> CONFIG_USB_MON=y
> -CONFIG_USB_EHCI_HCD=y
> CONFIG_USB_WDM=y
> CONFIG_USB_STORAGE=y
> CONFIG_USB_LIBUSUAL=y
> --
> 1.7.9.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-07-09 8:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-06 18:20 [PATCH] ARM: OMAP2+: omap2plus_defconfig: EHCI driver is not stable, disable it Kevin Hilman
2012-07-09 8:40 ` Tony Lindgren [this message]
2012-07-09 16:36 ` Kevin Hilman
2012-07-12 8:33 ` Munegowda, Keshava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120709084032.GZ1122@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).