From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2 V2] MXS: Set I2C timing registers for mxs-i2c
Date: Mon, 9 Jul 2012 13:07:35 +0200 [thread overview]
Message-ID: <201207091307.35860.marex@denx.de> (raw)
In-Reply-To: <20120709105338.GE1296@pengutronix.de>
Dear Wolfram Sang,
[...]
> > diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
> > index ee3778a..832d30a 100644
> > --- a/arch/arm/boot/dts/imx28.dtsi
> > +++ b/arch/arm/boot/dts/imx28.dtsi
[...]
> > @@ -428,6 +429,7 @@
> >
> > compatible = "fsl,imx28-i2c";
> > reg = <0x8005a000 2000>;
> > interrupts = <110 69>;
> >
> > + clock-frequency = <400000>;
>
> NACK on that. Not all slaves can do 400KHz, so this is not a sensible
> default.
How many of such chips are there and how many of the chips can do 400kHz ? I
believe the majority shouldn't suffer because of minority.
[...]
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-07-09 11:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-06 6:09 [PATCH 1/2 V2] MXS: Set I2C timing registers for mxs-i2c Marek Vasut
2012-07-06 6:09 ` [PATCH 2/2 V2] MXS: Implement DMA support into mxs-i2c Marek Vasut
2012-07-09 10:53 ` [PATCH 1/2 V2] MXS: Set I2C timing registers for mxs-i2c Wolfram Sang
2012-07-09 11:07 ` Marek Vasut [this message]
2012-07-09 12:05 ` Wolfram Sang
2012-07-09 15:58 ` Marek Vasut
2012-07-10 14:09 ` Robert Schwebel
2012-07-10 15:13 ` Marek Vasut
-- strict thread matches above, loose matches on Subject: below --
2012-06-08 18:54 Marek Vasut
2012-06-09 4:15 ` Shubhrajyoti Datta
2012-06-09 10:34 ` Marek Vasut
2012-06-09 10:53 ` Sascha Hauer
2012-06-09 11:11 ` Marek Vasut
2012-06-09 11:25 ` Sascha Hauer
2012-06-09 11:40 ` Marek Vasut
2012-06-09 12:46 ` Shubhrajyoti Datta
2012-06-09 13:10 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201207091307.35860.marex@denx.de \
--to=marex@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).