From: akpm@linux-foundation.org (Andrew Morton)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] ARM: clk-imx27: Fix rtc clock id
Date: Mon, 9 Jul 2012 14:18:27 -0700 [thread overview]
Message-ID: <20120709141827.14a45a9c.akpm@linux-foundation.org> (raw)
In-Reply-To: <1341694041-7839-1-git-send-email-festevam@gmail.com>
On Sat, 7 Jul 2012 17:47:19 -0300
Fabio Estevam <festevam@gmail.com> wrote:
> Fix rtc clock id.
>
> --- a/arch/arm/mach-imx/clk-imx27.c
> +++ b/arch/arm/mach-imx/clk-imx27.c
> @@ -256,7 +256,7 @@ int __init mx27_clocks_init(unsigned long fref)
> clk_register_clkdev(clk[gpio_ipg_gate], "gpio", NULL);
> clk_register_clkdev(clk[brom_ahb_gate], "brom", NULL);
> clk_register_clkdev(clk[ata_ahb_gate], "ata", NULL);
> - clk_register_clkdev(clk[rtc_ipg_gate], "rtc", NULL);
> + clk_register_clkdev(clk[rtc_ipg_gate], NULL, "mxc_rtc");
> clk_register_clkdev(clk[scc_ipg_gate], "scc", NULL);
> clk_register_clkdev(clk[cpu_div], "cpu", NULL);
> clk_register_clkdev(clk[emi_ahb_gate], "emi_ahb" , NULL);
When I look at this patch I don't know if it changes the user interface
(does it rename or move sysfs files or contents?) and I don't know
whether the patch fixes serious issues, which would indicate that a
backport into -stable is needed.
So, please read and remember these words: when fixing a bug, always
provide a complete description of that bug. Most especially, provide a
description of the end-user effects of the bug.
prev parent reply other threads:[~2012-07-09 21:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-07 20:47 [PATCH 1/3] ARM: clk-imx27: Fix rtc clock id Fabio Estevam
2012-07-07 20:47 ` [PATCH 2/3] rtc: rtc-mxc: Adapt to the new i.mx clock framework Fabio Estevam
2012-07-09 6:50 ` Sascha Hauer
2012-07-07 20:47 ` [PATCH 3/3] rtc: rtc-mxc: Convert to module_platform_driver Fabio Estevam
2012-07-09 6:51 ` [PATCH 1/3] ARM: clk-imx27: Fix rtc clock id Sascha Hauer
2012-07-09 21:18 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120709141827.14a45a9c.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).