From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2] i2c: imx: make bitrate an u32 type
Date: Tue, 10 Jul 2012 10:42:39 +0200 [thread overview]
Message-ID: <20120710084239.GZ30009@pengutronix.de> (raw)
In-Reply-To: <1341872910-26687-1-git-send-email-wolfram@the-dreams.de>
On Tue, Jul 10, 2012 at 12:28:30AM +0200, Wolfram Sang wrote:
> sparse found this assignment of u32 to an int. Fix it:
>
> drivers/i2c/busses/i2c-imx.c:540:56: warning: incorrect type in argument 3 (different signedness)
>
> and also fix the type in platform_data. All current users use values
> which fit into the old and new type, so it is a safe change.
>
> Signed-off-by: Wolfram Sang <wolfram@the-dreams.de>
> Cc: Richard Zhao <richard.zhao@freescale.com>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Sascha
> ---
>
> Changes since V1: also change type in platform_data. Thanks to Richard.
>
> arch/arm/plat-mxc/include/mach/i2c.h | 2 +-
> drivers/i2c/busses/i2c-imx.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/plat-mxc/include/mach/i2c.h b/arch/arm/plat-mxc/include/mach/i2c.h
> index 375cdd0..8289d91 100644
> --- a/arch/arm/plat-mxc/include/mach/i2c.h
> +++ b/arch/arm/plat-mxc/include/mach/i2c.h
> @@ -15,7 +15,7 @@
> *
> **/
> struct imxi2c_platform_data {
> - int bitrate;
> + u32 bitrate;
> };
>
> #endif /* __ASM_ARCH_I2C_H_ */
> diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
> index dd2a083..90460dd 100644
> --- a/drivers/i2c/busses/i2c-imx.c
> +++ b/drivers/i2c/busses/i2c-imx.c
> @@ -471,8 +471,8 @@ static int __init i2c_imx_probe(struct platform_device *pdev)
> struct imxi2c_platform_data *pdata = pdev->dev.platform_data;
> struct pinctrl *pinctrl;
> void __iomem *base;
> - int irq, bitrate;
> - int ret;
> + int irq, ret;
> + u32 bitrate;
>
> dev_dbg(&pdev->dev, "<%s>\n", __func__);
>
> --
> 1.7.10.4
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2012-07-10 8:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-09 22:28 [PATCH V2] i2c: imx: make bitrate an u32 type Wolfram Sang
2012-07-09 23:08 ` Richard Zhao
2012-07-10 8:42 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120710084239.GZ30009@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).