From: shiraz.hashim@st.com (Shiraz Hashim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/6] Clk: SPEAr1340: fix sys clock parent source and corresponding mask value
Date: Tue, 10 Jul 2012 14:22:13 +0530 [thread overview]
Message-ID: <20120710085213.GI29798@localhost.localdomain> (raw)
In-Reply-To: <20120709225700.GB16202@gmail.com>
Hi Mike,
On Mon, Jul 09, 2012 at 03:57:00PM -0700, Mike Turquette wrote:
> On 20120709-13:34, viresh kumar wrote:
> > On Mon, Jul 9, 2012 at 1:04 PM, vipul kumar samar
> > <vipulkumar.samar@st.com> wrote:
> > > On 7/9/2012 4:34 PM, viresh kumar wrote:
> > >>
> > >> On Mon, Jul 9, 2012 at 11:31 AM, Shiraz Hashim<shiraz.hashim@st.com>
> > >> wrote:
> > >>>
> > >>> From: Vipul Kumar Samar<vipulkumar.samar@st.com>
> > >>>
> > >>> sys_clk have multiple parents and selection of parent is depends on
> > >>
> > >>
> > >> s/ is//
> >
> > I hope you haven't missed this comment :)
> >
> > >>> static const char *vco_parents[] = { "osc_24m_clk", "osc_25m_clk", };
> > >>> -static const char *sys_parents[] = { "none", "pll1_clk", "none", "none",
> > >>> - "sys_synth_clk", "none", "pll2_clk", "pll3_clk", };
> > >>> +static const char *sys_parents[] = { "pll1_clk", "pll1_clk", "pll1_clk",
> > >>> + "pll1_clk", "sys_synth_clk", "sys_synth_clk", "pll2_clk",
> > >>> "pll3_clk", };
> > >>
> > >>
> > >> Don't know what would be the implication of this?
> > >>
> > >> @Mike: Can you please tell us what should we do in such cases?
> > >>
> > >
> > > Is there any other solution for such cases ???
> >
> > That's what i have asked mike for :)
> > Probably you can go through the clock framework code and check how these
> > names are used. Shouldn't be too complex to understand.
> >
>
> I assume this change has been tested and wouldn't be posted if modifying
> the parent names broke things.
Yes, it is working fine for us.
--
regards
Shiraz
next prev parent reply other threads:[~2012-07-10 8:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-09 10:31 [PATCH 1/6] ARM: DTS: SPEAr13xx: Fix Interrupt bindings Shiraz Hashim
2012-07-09 10:31 ` [PATCH 2/6] clk: SPEAr1340: Fix clk enable register for uart1 and i2c1 Shiraz Hashim
2012-07-09 10:55 ` viresh kumar
2012-07-09 10:31 ` [PATCH 3/6] clk: SPEAr13xx: Add localtimer (twd) clock support Shiraz Hashim
2012-07-09 10:57 ` viresh kumar
2012-07-09 10:31 ` [PATCH 4/6] Clk: SPEAr13xx: Initialize con_id for Ethernet phy clks Shiraz Hashim
2012-07-09 10:58 ` viresh kumar
2012-07-09 10:31 ` [PATCH 5/6] Clk: SPEAr1340: fix sys clock parent source and corresponding mask value Shiraz Hashim
2012-07-09 11:04 ` viresh kumar
2012-07-09 12:04 ` vipul kumar samar
2012-07-09 12:34 ` viresh kumar
2012-07-09 22:57 ` Mike Turquette
2012-07-10 8:21 ` Viresh Kumar
2012-07-11 20:11 ` Mike Turquette
2012-07-10 8:52 ` Shiraz Hashim [this message]
2012-07-09 10:53 ` [PATCH 1/6] ARM: DTS: SPEAr13xx: Fix Interrupt bindings viresh kumar
2012-07-09 11:18 ` [PATCH 6/6] ARM: SPEAr13xx: Add auxdata for Ethernet controller Shiraz Hashim
2012-07-09 11:30 ` viresh kumar
2012-07-09 12:29 ` vipul kumar samar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120710085213.GI29798@localhost.localdomain \
--to=shiraz.hashim@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).