From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] IIO: Add basic MXS LRADC driver
Date: Tue, 10 Jul 2012 12:08:51 +0200 [thread overview]
Message-ID: <201207101208.51168.marex@denx.de> (raw)
In-Reply-To: <201207101149.13908.jbe@pengutronix.de>
Dear Juergen Beisert,
> Hi Marek,
>
> Marek Vasut wrote:
> > > > > When I try to compile
> > > > > your code I get:
> > > > >
> > > > > drivers/staging/iio/adc/mxs-lradc.c:42:40: fatal error:
> > > > > linux/iio/triggered_buffer.h: No such file or directory
> > > >
> > > > You need this patches:
> > > > iio:kfifo_buf Take advantage of the fixed record size used in IIO
> > > > iio: kfifo - add poll support.
> > > >
> > > > And use latest -next.
> > >
> > > Thanks for the hints. Now it compiles and the driver seems to work.
> > >
> > > One thing I do not understand: It does not matter what channel I read
> > > ('in_voltage*_raw'), only interrupt 16 ('mxs-lradc-channel0') counts
> > > up. Intended?
> > > Or did I a mistake by adding interrupt numbers "<13 14 15 16 17 18 19
> > > 20 21 22 23 24 25>" to the corresponding device tree entry?
> >
> > They're wrong
> >
> > lradc at 80050000 {
> >
> > compatible = "fsl,imx28-lradc";
> > reg = <0x80050000 2000>;
> > interrupts = <10 14 15 16 17 18 19
> >
> > 20 21 22 23 24 25>;
> >
> > status = "disabled";
> >
> > };
>
> Ups, thanks. But still the same behaviour:
>
> $ cat /proc/interrupts
> [...]
> 10: 0 - mxs-lradc-touchscreen
> 14: 0 - mxs-lradc-thresh0
> 15: 0 - mxs-lradc-thresh1
> 16: 0 - mxs-lradc-channel0
> 17: 0 - mxs-lradc-channel1
> 18: 0 - mxs-lradc-channel2
> 19: 0 - mxs-lradc-channel3
> 20: 0 - mxs-lradc-channel4
> 21: 0 - mxs-lradc-channel5
> 22: 0 - mxs-lradc-channel6
> 23: 0 - mxs-lradc-channel7
> 24: 0 - mxs-lradc-button0
> 25: 0 - mxs-lradc-button1
> [...]
>
> $ cat in_voltage0_raw
> 524
> $ cat in_voltage1_raw
> 96
> $ cat in_voltage2_raw
> 1261
>
> $ cat /proc/interrupts
> [...]
> 10: 0 - mxs-lradc-touchscreen
> 14: 0 - mxs-lradc-thresh0
> 15: 0 - mxs-lradc-thresh1
> 16: 3 - mxs-lradc-channel0
> 17: 0 - mxs-lradc-channel1
> 18: 0 - mxs-lradc-channel2
> 19: 0 - mxs-lradc-channel3
> 20: 0 - mxs-lradc-channel4
> 21: 0 - mxs-lradc-channel5
> 22: 0 - mxs-lradc-channel6
> 23: 0 - mxs-lradc-channel7
> 24: 0 - mxs-lradc-button0
> 25: 0 - mxs-lradc-button1
> [...]
>
> Intended in this way?
But wait, you're getting interrupts on channel 0. Doesn't seem quite right. Did
you happen to poke into the code and see where the issue might be?
> Regards,
> Juergen
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-07-10 10:08 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-04 2:15 [PATCH] IIO: Add basic MXS LRADC driver Marek Vasut
2012-07-04 4:30 ` Wolfgang Denk
2012-07-04 8:35 ` Lars-Peter Clausen
2012-07-04 23:48 ` Marek Vasut
2012-07-05 8:33 ` Lars-Peter Clausen
2012-07-05 19:53 ` Marek Vasut
2012-07-19 14:23 ` Marek Vasut
2012-07-19 14:33 ` Lars-Peter Clausen
2012-07-19 15:15 ` Marek Vasut
2012-07-19 19:26 ` Marek Vasut
2012-07-20 2:18 ` Marek Vasut
2012-07-20 8:39 ` Robert Schwebel
2012-07-20 11:32 ` Marek Vasut
2012-07-20 14:09 ` Lars-Peter Clausen
2012-07-22 19:48 ` Jonathan Cameron
2012-07-20 14:11 ` Lars-Peter Clausen
2012-07-20 15:12 ` Marek Vasut
2012-07-09 9:19 ` Juergen Beisert
2012-07-09 9:52 ` Lars-Peter Clausen
2012-07-09 10:03 ` Marek Vasut
2012-07-10 9:20 ` Juergen Beisert
2012-07-10 9:26 ` Marek Vasut
2012-07-10 9:49 ` Juergen Beisert
2012-07-10 10:08 ` Marek Vasut [this message]
2012-07-10 10:26 ` Juergen Beisert
2012-07-10 10:35 ` Lars-Peter Clausen
2012-07-10 10:41 ` Juergen Beisert
2012-07-10 10:45 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201207101208.51168.marex@denx.de \
--to=marex@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).