From: marek.vasut@gmail.com (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v9 REBASE 6/9] USB: notify phy when root hub port connect change
Date: Tue, 10 Jul 2012 13:38:58 +0200 [thread overview]
Message-ID: <201207101338.58340.marex@denx.de> (raw)
In-Reply-To: <20120710112050.GH26888@b20223-02.ap.freescale.net>
Dear Richard Zhao,
[...]
> > > --- a/drivers/usb/core/hub.c
> > > +++ b/drivers/usb/core/hub.c
> > > @@ -1924,6 +1924,11 @@ void usb_disconnect(struct usb_device **pdev)
> > >
> > > */
> > >
> > > device_del(&udev->dev);
> > >
> > > + if (udev->parent && !udev->parent->parent) {
> > > + struct usb_hcd *hcd = bus_to_hcd(udev->bus);
> > > + usb_phy_notify_disconnect(hcd->phy, udev->portnum);
> > > + }
> >
> > Shouldn't that go before device_del() ?
>
> Any difference?
I was worried some corruption of other members in udev structure might happen,
but I'm not so sure anymore after taking deer look.
> Thanks
> Richard
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-07-10 11:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-07 14:56 [PATCH v9 REBASE 0/9] add imx usb driver based on Greg next tree Richard Zhao
2012-07-07 14:56 ` [PATCH v9 REBASE 1/9] USB: Chipidea: rename struct ci13xxx variables from udc to ci Richard Zhao
2012-07-07 14:56 ` [PATCH v9 REBASE 2/9] USB: Chipidea: add unified ci13xxx_{add, remove}_device for platform drivers Richard Zhao
2012-07-07 14:56 ` [PATCH v9 REBASE 3/9] USB: Chipidea: add ci13xxx device id management Richard Zhao
2012-07-07 14:56 ` [PATCH v9 REBASE 4/9] usb: chipidea: select USB_EHCI_ROOT_HUB_TT in USB_CHIPIDEA_HOST of Kconfig Richard Zhao
2012-07-07 14:56 ` [PATCH v9 REBASE 5/9] usb: otg: add notify_connect/notify_disconnect callback Richard Zhao
2012-07-07 14:56 ` [PATCH v9 REBASE 6/9] USB: notify phy when root hub port connect change Richard Zhao
2012-07-09 16:57 ` Greg KH
2012-07-10 1:44 ` Richard Zhao
2012-07-10 14:24 ` Alan Stern
2012-07-10 14:53 ` Richard Zhao
2012-07-10 3:14 ` Richard Zhao
2012-07-10 3:22 ` Marek Vasut
2012-07-10 11:20 ` Richard Zhao
2012-07-10 11:38 ` Marek Vasut [this message]
2012-07-10 15:07 ` Alan Stern
2012-07-11 2:53 ` Richard Zhao
2012-07-07 14:56 ` [PATCH v9 REBASE 7/9] usb: chipidea: permit driver bindings pass phy pointer Richard Zhao
2012-07-07 14:56 ` [PATCH v9 REBASE 8/9] usb: otg: add basic mxs phy driver support Richard Zhao
2012-07-07 14:56 ` [PATCH v9 REBASE 9/9] usb: chipidea: add imx platform driver Richard Zhao
2012-07-09 17:02 ` [PATCH v9 REBASE 0/9] add imx usb driver based on Greg next tree Greg KH
2012-07-10 1:52 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201207101338.58340.marex@denx.de \
--to=marek.vasut@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).