From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: Move designware timer OF glue into drivers/clocksource
Date: Tue, 10 Jul 2012 14:20:33 +0200 [thread overview]
Message-ID: <20120710142033.2786c434@skate> (raw)
In-Reply-To: <20120710094249.GF10225@elf.ucw.cz>
Le Tue, 10 Jul 2012 11:42:50 +0200,
Pavel Machek <pavel@denx.de> a ?crit :
> It seems mach-socfpga (not yet in tree, we are trying to merge it)
> would need pretty much direct copy of arch/arm/mach-picoxcell/time.c
> ... And because "just copying" it seems like quite bad idea, what
> about this, instead?
Of course, the idea sounds good. A few comments:
* Is a new file really needed? Wouldn't it be better to just add a
device tree binding to the existing dw_apb_timer driver?
* You're moving arch/arm/mach-picoxcell/time.c, but not updating any
mach-picoxcell Makefile, so I presume this would break the build.
* I'm not a big fan of the ../../../drivers/clocksource/...o in your
Makefile. What about using an hidden kconfig option in
drivers/clocksource/ that gets selected by your architecture, so
that the driver gets build? This is typically done for a few other
timer drivers in drivers/clocksource already.
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-07-10 12:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-10 9:42 Move designware timer OF glue into drivers/clocksource Pavel Machek
2012-07-10 11:07 ` Thomas Gleixner
2012-07-10 11:13 ` Pavel Machek
2012-07-10 14:10 ` Thomas Gleixner
2012-07-10 11:23 ` Pavel Machek
2012-07-10 11:24 ` Jamie Iles
2012-07-10 12:19 ` Pavel Machek
2012-07-10 13:41 ` Arnd Bergmann
2012-07-10 18:08 ` Pavel Machek
2012-07-10 12:20 ` Thomas Petazzoni [this message]
2012-07-10 18:11 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120710142033.2786c434@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox