From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCHv2 2/2] ARM: socfpga: Add board support for Altera's SOCFPGA Cyclone 5 HW
Date: Tue, 17 Jul 2012 09:20:14 +0200 [thread overview]
Message-ID: <20120717092014.53392f77@skate> (raw)
In-Reply-To: <50049916.3080509@gmail.com>
Le Mon, 16 Jul 2012 17:43:34 -0500,
Rob Herring <robherring2@gmail.com> a ?crit :
> > diff --git a/arch/arm/mach-socfpga/Kconfig b/arch/arm/mach-socfpga/Kconfig
> > new file mode 100644
> > index 0000000..133fc89
> > --- /dev/null
> > +++ b/arch/arm/mach-socfpga/Kconfig
> > @@ -0,0 +1,7 @@
> > +config MACH_SOCFPGA_CYCLONE5
> > + bool "SOCFPGA Cyclone5 platform"
> > + select COMMON_CLK
> > + select HAVE_SMP
> > + select PLAT_SOCFPGA_ETH
> > + help
> > + Include support for the Altera(R) Cyclone5 development platform.
>
> You don't need a config option for a machine with DT.
Ah, interesting, I was precisely going to send an e-mail today about
this, because we currently have different cases in tree:
* In mach-tegra/Kconfig, there is one Kconfig option per-board, and
then mach-tegra/Makefile.boot contains lines like
dtb-$(CONFIG_MACH_<board>) += <board>.dtb. So there is one Kconfig
option per-board, and a .dtb generation per-board.
* In mach-at91/Kconfig, there is only one Kconfig option to support
all DT-based platforms (CONFIG_MACH_AT91SAM_DT), and
mach-at91/Makefile.boot generates the .dtb files for all boards as
soon as CONFIG_MACH_AT91SAM_DT is enabled. So very different
strategy from mach-tegra.
* In mach-mxs/Kconfig, there is only one Kconfig option to support all
DT-based platforms (MACH_MXS_DT), but the mach-mxs/Makefile.boot
does not have any dtb-... += line.
Which approach is the correct one? My feeling would be that the
mach-at91 approach is the right one, because it doesn't make sense to
have one Kconfig option per board when we use the device tree. Is this
correct?
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-07-17 7:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 17:26 [RFC PATCHv2 0/2]arm: socfpga: Add initial support for Altera's SOCFPGA HW dinguyen at altera.com
2012-07-12 17:26 ` [RFC PATCHv2 1/2] ARM: socfpga: initial support for Altera's SOCFPGA platform dinguyen at altera.com
2012-07-16 22:46 ` Rob Herring
2012-07-17 15:47 ` Arnd Bergmann
2012-07-17 21:31 ` Dinh.Nguyen
2012-07-17 21:23 ` Arnd Bergmann
2012-07-12 17:26 ` [RFC PATCHv2 2/2] ARM: socfpga: Add board support for Altera's SOCFPGA Cyclone 5 HW dinguyen at altera.com
2012-07-16 22:43 ` Rob Herring
2012-07-17 7:20 ` Thomas Petazzoni [this message]
2012-07-17 7:13 ` Thomas Petazzoni
2012-07-17 15:44 ` Dinh.Nguyen
2012-07-17 15:56 ` Arnd Bergmann
2012-07-16 21:37 ` [RFC PATCHv2 0/2]arm: socfpga: Add initial support for Altera's SOCFPGA HW Pavel Machek
2012-07-17 15:43 ` Arnd Bergmann
2012-07-17 16:46 ` Dinh.Nguyen
2012-07-18 10:35 ` Pavel Machek
2012-07-18 10:36 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120717092014.53392f77@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).