From: shiraz.hashim@st.com (Shiraz Hashim)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL] SPEAr platform fixes over 3.5-rc7
Date: Wed, 18 Jul 2012 11:46:26 +0530 [thread overview]
Message-ID: <20120718061626.GR1994@localhost.localdomain> (raw)
In-Reply-To: <CAOesGMhgdQKhfdZWq32ideX-m2-_Y=ANxBF+eMwgxFCkZpc_iQ@mail.gmail.com>
Hi Olof,
On Tue, Jul 17, 2012 at 10:58:46PM -0700, Olof Johansson wrote:
> Thanks for the quick turnaround. I've pulled this branch into fixes
> and will send it up to Linus tonight or tomorrow morning once the at91
> branch has been sorted out too.
OK. Thanks.
> One remaining nit: Your signed-off-by lines should be the very last
> line, since you were the last person to touch the patch. You would
> normally add Acked-by lines that came in above your own S-o-b, not
> below. Please keep that in mind for future patches (if you use git am
> -s then git will handle this automatically).
Oh. Sorry for my ignorance, would take care in future.
One question though, what if I already have commits in my repo and I
am not applying them from email. How to quickly add signed-off-by
lines to existing commits in a branch.
--
regards
Shiraz
prev parent reply other threads:[~2012-07-18 6:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-17 13:01 [GIT PULL] SPEAr platform fixes over 3.5-rc7 Shiraz Hashim
2012-07-18 3:43 ` Olof Johansson
2012-07-18 4:22 ` Shiraz Hashim
2012-07-18 5:29 ` Shiraz Hashim
2012-07-18 5:58 ` Olof Johansson
2012-07-18 6:16 ` Shiraz Hashim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120718061626.GR1994@localhost.localdomain \
--to=shiraz.hashim@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).