[GIT PULL] SPEAr platform fixes over 3.5-rc7

[GIT PULL] SPEAr platform fixes over 3.5-rc7

[Shiraz Hashim]

Hi Arnd,

Please pull following fixes since commit 84a1caf1453c3d44050bd22db958af4a7f99315c:

  Linux 3.5-rc7 (2012-07-14 15:40:28 -0700)

from git repository at:

  git://git.stlinux.com/spear/linux-2.6.git for-3.5-spear-fixes

with changes up to b35b8e4e63618f17dc61520515ccdcf10e6d2b57:

  ARM: SPEAr600: Fix timer interrupt definition in spear600.dtsi (2012-07-17 18:04:48 +0530)

----------------------------------------------------------------
Stefan Roese (1):
      ARM: SPEAr600: Fix timer interrupt definition in spear600.dtsi

Vipul Kumar Samar (10):
      clk:spear1340:Fix: Rename clk ids within predefined limit
      clk:spear1310:Fix: Rename clk ids within predefined limit
      Clk:spear3xx:Fix: Rename clk ids within predefined limit
      Clk:spear6xx:Fix: Rename clk ids within predefined limit
      ARM: SPEAr13xx: Fix Interrupt bindings
      clk: SPEAr1340: Fix clk enable register for uart1 and i2c1.
      clk: SPEAr13xx: Add localtimer (twd) clock support
      Clk: SPEAr1340: Update sys clock parent array
      ARM: dts: SPEAr320: Fix compatible string
      ARM: dts: SPEAr320: Boot the board in EXTENDED_MODE

 arch/arm/boot/dts/spear13xx.dtsi    |   11 +-
 arch/arm/boot/dts/spear320-evb.dts  |    6 +-
 arch/arm/boot/dts/spear600.dtsi     |    1 +
 arch/arm/mach-spear3xx/spear3xx.c   |    2 +-
 arch/arm/mach-spear6xx/spear6xx.c   |    2 +-
 drivers/clk/spear/spear1310_clock.c |  316 ++++++++++++++++++-----------------
 drivers/clk/spear/spear1340_clock.c |  283 +++++++++++++++----------------
 drivers/clk/spear/spear3xx_clock.c  |  180 ++++++++++----------
 drivers/clk/spear/spear6xx_clock.c  |  122 +++++++-------
 9 files changed, 459 insertions(+), 464 deletions(-)

--
regards
Shiraz

[GIT PULL] SPEAr platform fixes over 3.5-rc7

[Olof Johansson]

Hi Shiraz,

I see that every commit in that branch is done by you, but not a
single one has a Signed-off-by by you. Please fix that, it's important
to track the history of how code is introduced to the kernel.

Also, we are _very_ late in the 3.5 release cycle now. Only truly
critical fixes can go in (3.5 is likely to come out by the weekend). I
have some comments about the patches below.

In general, to make our life easier, please make sure the commit
message for the patch describes why the fix is needed when it's not
obvious.

I'll wait with pulling until you have a chance to fix up your branch
based on the below comments. Please make sure you do it with extreme
expediency though, or chances are it'll miss 3.5.


Thanks,

-Olof

On Tue, Jul 17, 2012 at 6:01 AM, Shiraz Hashim <shiraz.hashim@st.com> wrote:

> Vipul Kumar Samar (10):
>       clk:spear1340:Fix: Rename clk ids within predefined limit
>       clk:spear1310:Fix: Rename clk ids within predefined limit
>       Clk:spear3xx:Fix: Rename clk ids within predefined limit
>       Clk:spear6xx:Fix: Rename clk ids within predefined limit

Ok, those 4 are quite obvious why they're needed.

>       ARM: SPEAr13xx: Fix Interrupt bindings
>       clk: SPEAr1340: Fix clk enable register for uart1 and i2c1.

Those two as well.

>       clk: SPEAr13xx: Add localtimer (twd) clock support

This doesn't look like a critical regression fix, does it?

>       Clk: SPEAr1340: Update sys clock parent array

Please help us out here by describing what is broken by the way it was
before the patch.

>       ARM: dts: SPEAr320: Fix compatible string

This one seems straightforward.

>       ARM: dts: SPEAr320: Boot the board in EXTENDED_MODE

Same here, please elaborate on why / how it is broken today.


Thanks,

-Olof

[GIT PULL] SPEAr platform fixes over 3.5-rc7

[Shiraz Hashim]

Hi Olof,

On Tue, Jul 17, 2012 at 08:43:34PM -0700, Olof Johansson wrote:
> Hi Shiraz,
> 
> I see that every commit in that branch is done by you, but not a
> single one has a Signed-off-by by you. Please fix that, it's important
> to track the history of how code is introduced to the kernel.

Sorry, I would take care for this and all future pull requests.

> Also, we are _very_ late in the 3.5 release cycle now. Only truly
> critical fixes can go in (3.5 is likely to come out by the weekend). I
> have some comments about the patches below.
> 
> In general, to make our life easier, please make sure the commit
> message for the patch describes why the fix is needed when it's not
> obvious.

Sure.

> I'll wait with pulling until you have a chance to fix up your branch
> based on the below comments. Please make sure you do it with extreme
> expediency though, or chances are it'll miss 3.5.

OK.

> On Tue, Jul 17, 2012 at 6:01 AM, Shiraz Hashim <shiraz.hashim@st.com> wrote:
> 
> >       clk: SPEAr13xx: Add localtimer (twd) clock support
> 
> This doesn't look like a critical regression fix, does it?

Yes, twd would rely on its calibration if we don't pass it.
Although it would break other stuff like cpu-freq, but they are not
yet upstreamed.

I would remove it from fixes branch and schedule it later.

> >       Clk: SPEAr1340: Update sys clock parent array
> 
> Please help us out here by describing what is broken by the way it was
> before the patch.

Out of several possibilities (h/w wise) to select same clock parent,
Linux was considering just one value. When bootloader programmed
different (valid) value to select a clock parent then Linux breaks.

Here, we just try to list all possibilities which can lead to same
clock selection thus making Linux independent of bootloader selection
values.

This was discussed in following thread
http://www.spinics.net/lists/arm-kernel/msg183554.html

> >       ARM: dts: SPEAr320: Fix compatible string
> 
> This one seems straightforward.
> 
> >       ARM: dts: SPEAr320: Boot the board in EXTENDED_MODE
> 
> Same here, please elaborate on why / how it is broken today.

spear320-evb board is designed for EXTENDED_MODE only, hence it would
not boot correctly in current form (pinctrl part for some devices would
fail). I would update the commit message.

Thanks for review. I would update the branch as soon as possible and
send a fresh pull request.

--
regards
Shiraz

[GIT PULL] SPEAr platform fixes over 3.5-rc7

[Shiraz Hashim]

Hi Olof,

On Tue, Jul 17, 2012 at 08:43:34PM -0700, Olof Johansson wrote:
> Hi Shiraz,
> 
> I see that every commit in that branch is done by you, but not a
> single one has a Signed-off-by by you. Please fix that, it's important
> to track the history of how code is introduced to the kernel.
> 
> Also, we are _very_ late in the 3.5 release cycle now. Only truly
> critical fixes can go in (3.5 is likely to come out by the weekend). I
> have some comments about the patches below.
> 
> In general, to make our life easier, please make sure the commit
> message for the patch describes why the fix is needed when it's not
> obvious.
> 
> I'll wait with pulling until you have a chance to fix up your branch
> based on the below comments. Please make sure you do it with extreme
> expediency though, or chances are it'll miss 3.5.

I have tried to fix all points mentioned by you and updated the spear
fixes branch.

The following changes since commit 84a1caf1453c3d44050bd22db958af4a7f99315c:

  Linux 3.5-rc7 (2012-07-14 15:40:28 -0700)

are available in the git repository at:

  http://git.stlinux.com/spear/linux-2.6.git for-3.5-spear-fixes

for you to fetch changes up to 69c7e3772eaee5d2097725cdb79bc3ef867c0d9e:

  ARM: SPEAr600: Fix timer interrupt definition in spear600.dtsi (2012-07-18 10:05:05 +0530)

----------------------------------------------------------------
Stefan Roese (1):
      ARM: SPEAr600: Fix timer interrupt definition in spear600.dtsi

Vipul Kumar Samar (9):
      clk:spear1340:Fix: Rename clk ids within predefined limit
      clk:spear1310:Fix: Rename clk ids within predefined limit
      Clk:spear3xx:Fix: Rename clk ids within predefined limit
      Clk:spear6xx:Fix: Rename clk ids within predefined limit
      ARM: SPEAr13xx: Fix Interrupt bindings
      clk: SPEAr1340: Fix clk enable register for uart1 and i2c1.
      Clk: SPEAr1340: Update sys clock parent array
      ARM: dts: SPEAr320: Fix compatible string
      ARM: dts: SPEAr320: Boot the board in EXTENDED_MODE

 arch/arm/boot/dts/spear13xx.dtsi    |   11 +-
 arch/arm/boot/dts/spear320-evb.dts  |    6 +-
 arch/arm/boot/dts/spear600.dtsi     |    1 +
 arch/arm/mach-spear3xx/spear3xx.c   |    2 +-
 arch/arm/mach-spear6xx/spear6xx.c   |    2 +-
 drivers/clk/spear/spear1310_clock.c |  312 +++++++++++++++++------------------
 drivers/clk/spear/spear1340_clock.c |  279 ++++++++++++++++---------------
 drivers/clk/spear/spear3xx_clock.c  |  180 ++++++++++----------
 drivers/clk/spear/spear6xx_clock.c  |  122 +++++++-------
 9 files changed, 451 insertions(+), 464 deletions(-)

--
regards
Shiraz

[GIT PULL] SPEAr platform fixes over 3.5-rc7

[Olof Johansson]

On Tue, Jul 17, 2012 at 10:29 PM, Shiraz Hashim <shiraz.hashim@st.com> wrote:
> Hi Olof,
>
> On Tue, Jul 17, 2012 at 08:43:34PM -0700, Olof Johansson wrote:
>> Hi Shiraz,
>>
>> I see that every commit in that branch is done by you, but not a
>> single one has a Signed-off-by by you. Please fix that, it's important
>> to track the history of how code is introduced to the kernel.
>>
>> Also, we are _very_ late in the 3.5 release cycle now. Only truly
>> critical fixes can go in (3.5 is likely to come out by the weekend). I
>> have some comments about the patches below.
>>
>> In general, to make our life easier, please make sure the commit
>> message for the patch describes why the fix is needed when it's not
>> obvious.
>>
>> I'll wait with pulling until you have a chance to fix up your branch
>> based on the below comments. Please make sure you do it with extreme
>> expediency though, or chances are it'll miss 3.5.
>
> I have tried to fix all points mentioned by you and updated the spear
> fixes branch.
>
> The following changes since commit 84a1caf1453c3d44050bd22db958af4a7f99315c:
>
>   Linux 3.5-rc7 (2012-07-14 15:40:28 -0700)
>
> are available in the git repository at:
>
>   http://git.stlinux.com/spear/linux-2.6.git for-3.5-spear-fixes

Thanks for the quick turnaround. I've pulled this branch into fixes
and will send it up to Linus tonight or tomorrow morning once the at91
branch has been sorted out too.

One remaining nit: Your signed-off-by lines should be the very last
line, since you were the last person to touch the patch. You would
normally add Acked-by lines that came in above your own S-o-b, not
below. Please keep that in mind for future patches (if you use git am
-s then git will handle this automatically).


-Olof

[GIT PULL] SPEAr platform fixes over 3.5-rc7

[Shiraz Hashim]

Hi Olof,

On Tue, Jul 17, 2012 at 10:58:46PM -0700, Olof Johansson wrote:
> Thanks for the quick turnaround. I've pulled this branch into fixes
> and will send it up to Linus tonight or tomorrow morning once the at91
> branch has been sorted out too.

OK. Thanks.

> One remaining nit: Your signed-off-by lines should be the very last
> line, since you were the last person to touch the patch. You would
> normally add Acked-by lines that came in above your own S-o-b, not
> below. Please keep that in mind for future patches (if you use git am
> -s then git will handle this automatically).

Oh. Sorry for my ignorance, would take care in future.

One question though, what if I already have commits in my repo and I
am not applying them from email. How to quickly add signed-off-by
lines to existing commits in a branch.

--
regards
Shiraz