From mboxrd@z Thu Jan 1 00:00:00 1970 From: shiraz.hashim@st.com (Shiraz Hashim) Date: Wed, 18 Jul 2012 11:46:26 +0530 Subject: [GIT PULL] SPEAr platform fixes over 3.5-rc7 In-Reply-To: References: <20120717130150.GM1994@localhost.localdomain> <20120718052911.GQ1994@localhost.localdomain> Message-ID: <20120718061626.GR1994@localhost.localdomain> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Olof, On Tue, Jul 17, 2012 at 10:58:46PM -0700, Olof Johansson wrote: > Thanks for the quick turnaround. I've pulled this branch into fixes > and will send it up to Linus tonight or tomorrow morning once the at91 > branch has been sorted out too. OK. Thanks. > One remaining nit: Your signed-off-by lines should be the very last > line, since you were the last person to touch the patch. You would > normally add Acked-by lines that came in above your own S-o-b, not > below. Please keep that in mind for future patches (if you use git am > -s then git will handle this automatically). Oh. Sorry for my ignorance, would take care in future. One question though, what if I already have commits in my repo and I am not applying them from email. How to quickly add signed-off-by lines to existing commits in a branch. -- regards Shiraz