Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: linuxzsc@gmail.com (Richard Zhao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] USB: chipidea: add imx usbmisc support
Date: Wed, 18 Jul 2012 21:39:40 +0800	[thread overview]
Message-ID: <20120718133938.GA2198@richard-laptop> (raw)
In-Reply-To: <20120718111916.GL21635@b20223-02.ap.freescale.net>

[snip]
> > >  static struct ci13xxx_platform_data ci13xxx_imx_platdata __devinitdata  = {
> > >  	.name			= "ci13xxx_imx",
> > >  	.flags			= CI13XXX_REQUIRE_TRANSCEIVER |
> > > @@ -120,6 +140,9 @@ static int __devinit ci13xxx_imx_probe(struct platform_device *pdev)
> > >  		*pdev->dev.dma_mask = DMA_BIT_MASK(32);
> > >  		dma_set_coherent_mask(&pdev->dev, *pdev->dev.dma_mask);
> > >  	}
> > > +
> > > +	usbmisc_ops->init(&pdev->dev);
> > 
> > usbmisc_ops can be NULL and also can return an error.
> Yes. And I find it can not work when usbmisc is module.
It's hard to resolve module dependency. How about build all imx related
things into a single module? ci13xxx_imx module init will call
usbmisc_imx6q_drv_init, usbmisc_imx53_drv_init etc.

Thanks
Richard

  parent reply	other threads:[~2012-07-18 13:39 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-18 10:29 [PATCH v2 0/2] imx: add usbmisc support Richard Zhao
2012-07-18 10:29 ` [PATCH v2 1/2] USB: chipidea: add imx " Richard Zhao
2012-07-18 10:52   ` Sascha Hauer
2012-07-18 11:19     ` Richard Zhao
2012-07-18 11:36       ` Sascha Hauer
2012-07-18 13:39       ` Richard Zhao [this message]
2012-07-18 13:43         ` Marc Kleine-Budde
2012-07-18 13:49           ` Richard Zhao
2012-07-23  9:16   ` Felipe Balbi
2012-07-23  9:27     ` Richard Zhao
2012-07-23  9:30       ` Marc Kleine-Budde
2012-07-23 10:51         ` Felipe Balbi
2012-07-23 11:13           ` Richard Zhao
2012-07-23 11:21             ` Felipe Balbi
2012-07-23 11:45               ` Richard Zhao
2012-07-18 10:29 ` [PATCH v2 2/2] ARM: dts: imx6q-sabrelite: add usbmisc device Richard Zhao
2012-07-18 10:54   ` Sascha Hauer
2012-07-18 11:22     ` Richard Zhao
2012-07-18 15:00   ` Shawn Guo
2012-07-19  2:02     ` Richard Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120718133938.GA2198@richard-laptop \
    --to=linuxzsc@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox