linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: Linux ARM with XZ compression issue
Date: Thu, 19 Jul 2012 11:13:29 +0200	[thread overview]
Message-ID: <201207191113.29529.marex@denx.de> (raw)
In-Reply-To: <CAJfuBxxpGqBeD1O3QfXLhHmMGBEFvy5XZOFLH6Xww33Y+7P_Ow@mail.gmail.com>

Dear Jim Cromie,

Note, try keeping the CC list please

> hi again,
> 
> On Wed, Jul 18, 2012 at 4:24 PM, Marek Vasut <marex@denx.de> wrote:
> > Dear Jim Cromie,
> > 
> >> hi Marek,
> >> 
> >> Surprising problem - is strstr the only one missing ?
> > 
> > I think so.
> > 
> >> Its only used in the stub fn, so you could cheat and
> >> just return 0, or warn less discriminately and return 0.
> >> Obviously, that wouldnt be acceptable for mainline.
> > 
> > Correct, so I'm looking for proper solution.
> 
> Ok.  I think youre on the right track - ie adding the fn.
> 
> just one more thought -
> add a strcmp call into the func, see if it compiles or breaks
> the same way.  If it breaks, theres a larger build issue,
> and Im not sure how LKML would react.

Hm, looks like strcmp is also missing, even though it's declared in

arch/arm/boot/compressed/string.c

> >> What happens if you build with compression other than XZ ?
> > 
> > LZMA is good, GZ as well.
> 
> ok, thats good -
> It suggests the problem is quite localized.
> 
> I suppose strcmp could still be missing,
> and possibly more likely, since the issue is so localized,
> and not exposed by other builds in other arches.
> 
> Do you already know where strstr should be added ?

arch/arm/boot/compressed/string.c I believe.

> Im asking cuz Im completely unfamiliar with arm,
> but did recently buy a raspberry-PI, so I'll be starting
> to hack on that eventually :-)
> 
> >> is it specific to XZ as you said, or a more general problem ?
> > 
> > Specific to XZ.
> > 

[...]

Best regards,
Marek Vasut

      parent reply	other threads:[~2012-07-19  9:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-18 14:34 Linux ARM with XZ compression issue Marek Vasut
     [not found] ` <CAJfuBxxKD_sF3DXZ8bUbSKcvxJY8ngXbHQmp0FBpV-Qytsw5XQ@mail.gmail.com>
2012-07-18 22:24   ` Marek Vasut
     [not found]     ` <CAJfuBxxpGqBeD1O3QfXLhHmMGBEFvy5XZOFLH6Xww33Y+7P_Ow@mail.gmail.com>
2012-07-19  9:13       ` Marek Vasut [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201207191113.29529.marex@denx.de \
    --to=marex@denx.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).