linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/6] csb1724: Enable device tree based mv643xx ethernet support.
Date: Mon, 30 Jul 2012 18:17:43 +0200	[thread overview]
Message-ID: <20120730161743.GN18016@lunn.ch> (raw)
In-Reply-To: <1343661359-10150-6-git-send-email-ian.molton@codethink.co.uk>

On Mon, Jul 30, 2012 at 04:15:58PM +0100, Ian Molton wrote:
>     This patch enables mv643xx based ethernet built into the SoM on the
>     csb1724, via flattened device tree.
> 
>     Signed-off-by: Ian Molton <ian.molton@codethink.co.uk>
> ---
>  arch/arm/boot/dts/kirkwood-csb1724.dts |   25 ++++++++++++++++++
>  arch/arm/boot/dts/kirkwood.dtsi        |   16 ++++++++++++
>  arch/arm/configs/csb1724_defconfig     |   45 ++++++++++++++++++++++++++++++++
>  arch/arm/mach-kirkwood/board-csb1724.c |    3 +++
>  4 files changed, 89 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/kirkwood-csb1724.dts b/arch/arm/boot/dts/kirkwood-csb1724.dts
> index 44dfe9a..f652797 100644
> --- a/arch/arm/boot/dts/kirkwood-csb1724.dts
> +++ b/arch/arm/boot/dts/kirkwood-csb1724.dts
> @@ -25,6 +25,31 @@
>  			nr-ports = <2>;
>  			status = "ok";
>  		};
> +
> +		smi0: mdio at 72000 {
> +			status = "ok";
> +		};
> +
> +		smi1: mdio at 76000 {
> +			status = "ok";
> +		};
> +
> +		egiga0 {
> +			compatible = "marvell,mv643xx";
> +			mdio = <&smi0>;
> +			port_number = <0>;
> +			phy_addr = <0x80>;
> +			interrupts = <11>;
> +		};

Hi Ian

Shouldn't there be two interrupt here?

 292         orion_ge00_init(eth_data,
 293                         GE00_PHYS_BASE, IRQ_KIRKWOOD_GE00_SUM,
 294                         IRQ_KIRKWOOD_GE00_ERR);

Documentation of the binding would help....

     Andrew

  parent reply	other threads:[~2012-07-30 16:17 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-30 15:15 [PATCH 0/6] mv643xx Ethernet DT support and CSB1724 board support Ian Molton
2012-07-30 15:15 ` [PATCH 1/6] Initial csb1724 board support (FDT) Ian Molton
2012-07-30 15:28   ` Andrew Lunn
2012-07-30 16:28     ` Ian Molton
2012-07-31 11:27       ` Arnd Bergmann
2012-07-30 15:15 ` [PATCH 2/6] mv643xx.c: Remove magic numbers Ian Molton
2012-07-30 15:15 ` [PATCH 3/6] mv643xx.c: Add basic device tree support Ian Molton
2012-07-30 15:39   ` Andrew Lunn
2012-07-30 16:49     ` Ian Molton
2012-07-30 16:19   ` Amar Nath
2012-07-30 16:32     ` Ian Molton
2012-07-31 15:12       ` Florian Fainelli
2012-07-31  7:14   ` Arnaud Patard (Rtp)
2012-07-31  8:19     ` Ian Molton
2012-07-31  8:27       ` Andrew Lunn
2012-07-31  8:45         ` Ian Molton
2012-07-31  8:58           ` Arnaud Patard (Rtp)
2012-07-31  9:14             ` Ian Molton
2012-07-31 14:30     ` Ben Dooks
2012-07-31 15:04       ` Arnaud Patard (Rtp)
2012-07-30 15:15 ` [PATCH 4/6] kirkwood: setup clock only in eth helpers Ian Molton
2012-07-30 16:12   ` Andrew Lunn
2012-07-30 16:52     ` Ian Molton
2012-07-30 19:10       ` Andrew Lunn
2012-07-30 16:46   ` Josh Coombs
2012-07-31  8:23     ` Ian Molton
2012-07-31 11:04     ` Ian Molton
2012-07-31 11:08       ` Andrew Lunn
2012-07-31 11:39         ` Ian Molton
2012-07-30 15:15 ` [PATCH 5/6] csb1724: Enable device tree based mv643xx ethernet support Ian Molton
2012-07-30 15:55   ` Andrew Lunn
2012-07-30 16:58     ` Ian Molton
2012-07-30 16:17   ` Andrew Lunn [this message]
2012-07-30 16:57     ` Ian Molton
2012-07-30 15:15 ` [PATCH 6/6] DT: Convert all kirkwood boards with mv643xx that use DT Ian Molton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120730161743.GN18016@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).