From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/3] ARM: omap: clk: add clk_prepare and clk_unprepare
Date: Tue, 31 Jul 2012 10:27:14 +0100 [thread overview]
Message-ID: <20120731092714.GL7405@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <50179584.9070006@codeaurora.org>
On Tue, Jul 31, 2012 at 01:21:24AM -0700, Saravana Kannan wrote:
> I have heard this idea about removing the clk_prepare/unprepare API too
> many times and it makes me uncomfortable. I would really prefer we (the
> community) take this discussion to the end and put an end to it. We
> either agree to stick with the clk_prepare APIs or figure out the newer
> APIs. I don't want to keep having to deal with the "we really should be
> removing the clk_prepare() APIs" wrench thrown into the discussion every
> time we discuss anything related to a locking issue.
Well, part of the motivation to remove it comes from the fact that we
have this "clk_prepare_enable()" thing which _everyone_ simply converts
their existing clk_enable() call to without _thinking_ one little bit
about the rest of the picture.
It's that which is making the justification for getting rid of the split
API soo easy. If people put more thought into it then the separation of
the two calls would be much clearer, and there would be more of a
justification to prevent its removal.
next prev parent reply other threads:[~2012-07-31 9:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 10:24 [PATCH v3 0/3] Prepare for OMAP2+ movement to Common Clk Rajendra Nayak
2012-07-02 10:24 ` [PATCH v3 1/3] ARM: omap: clk: add clk_prepare and clk_unprepare Rajendra Nayak
2012-07-30 22:31 ` Paul Walmsley
2012-07-30 22:42 ` Turquette, Mike
2012-07-30 23:02 ` Russell King - ARM Linux
2012-07-31 0:31 ` Turquette, Mike
2012-07-31 8:21 ` Saravana Kannan
2012-07-31 9:27 ` Russell King - ARM Linux [this message]
2012-07-31 9:23 ` Russell King - ARM Linux
2012-07-31 18:00 ` Paul Walmsley
2012-07-02 10:24 ` [PATCH v3 2/3] ARM: omap: hwmod: get rid of all omap_clk_get_by_name usage Rajendra Nayak
2012-07-02 10:24 ` [PATCH v3 3/3] ARM: omap: clk: Remove all direct dereferencing of struct clk Rajendra Nayak
2012-07-30 7:12 ` Paul Walmsley
2012-07-30 7:36 ` Rajendra Nayak
2012-07-30 18:56 ` Paul Walmsley
2012-07-31 6:05 ` Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120731092714.GL7405@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).