From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [06/10,V2] spi: Add SPI driver for mx233/mx28
Date: Wed, 1 Aug 2012 06:48:05 +0200 [thread overview]
Message-ID: <201208010648.05325.marex@denx.de> (raw)
In-Reply-To: <20120801035333.GB1672@S2100-06.ap.freescale.net>
Dear Shawn Guo,
> On Wed, Aug 01, 2012 at 04:31:04AM +0200, Marek Vasut wrote:
> > > Couple of reasons for asking: No other SPI master driver calls it in
> > > the remove function (unless I missed it), most drivers don't call it
> > > in the probe function error path, and if I call it in the remove
> > > function in a SPI master driver I am working on, and load/unload the
> > > module several times in a row, I get a nasty kernel crash.
> >
> > It seems the spi_master class takes care of that kfree() in
> > spi.c:spi_master_release() . Good catch, thanks!
>
> I do not hardware setup to confirm that right away. When
> spi_master_release will be called exactly? The time that
> spi_master_put gets called? I'm trying to understand if the kfree
> is not needed only in remove function, or both probe and remove.
I checked, it's called in both cases ... (if .probe() crashes, release() is
called, so kfree() is unneeded)
> Regards,
> Shawn
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-08-01 4:48 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-06 6:17 [PATCH 01/10 RESEND] mmc: spi: Move SSP register definitions into separate file Marek Vasut
2012-07-06 6:17 ` [PATCH 02/10 RESEND] mmc: spi: Rename IMX2[38]_MMC to IMX2[38]_SSP Marek Vasut
2012-07-06 6:17 ` [PATCH 03/10 RESEND] mmc: spi: Add necessary bits into mxs-spi.h Marek Vasut
2012-07-06 6:17 ` [PATCH 04/10 RESEND] mmc: spi: Pull out parts shared between MMC and SPI Marek Vasut
2012-07-16 7:57 ` Attila Kinali
2012-07-16 10:59 ` Marek Vasut
2012-07-16 11:32 ` Attila Kinali
2012-07-06 6:17 ` [PATCH 05/10 RESEND] mmc: spi: Pull out the SSP clock configuration function Marek Vasut
2012-07-06 6:17 ` [PATCH 06/10 V2] spi: Add SPI driver for mx233/mx28 Marek Vasut
2012-07-31 20:53 ` [06/10,V2] " Guenter Roeck
2012-08-01 2:31 ` Marek Vasut
2012-08-01 3:34 ` Guenter Roeck
2012-08-01 3:53 ` Shawn Guo
2012-08-01 3:35 ` Guenter Roeck
2012-08-01 4:50 ` Shawn Guo
2012-08-01 5:00 ` Marek Vasut
2012-08-01 5:29 ` Guenter Roeck
2012-08-01 5:46 ` Shubhrajyoti Datta
2012-08-01 6:36 ` Guenter Roeck
2012-08-01 6:41 ` Marek Vasut
2012-08-01 5:58 ` Shawn Guo
2012-08-01 5:42 ` Guenter Roeck
2012-08-01 6:28 ` Shawn Guo
2012-08-01 6:10 ` Marek Vasut
2012-08-01 6:39 ` Guenter Roeck
2012-08-01 6:45 ` Marek Vasut
2012-08-01 6:56 ` Guenter Roeck
2012-08-01 7:50 ` Shawn Guo
2012-08-01 14:58 ` Guenter Roeck
2012-08-01 7:40 ` Shawn Guo
2012-08-01 7:38 ` Lothar Waßmann
2012-08-01 8:20 ` Shawn Guo
2012-08-01 7:47 ` Shawn Guo
2012-08-01 6:33 ` Guenter Roeck
2012-08-01 6:40 ` Marek Vasut
2012-08-01 4:48 ` Marek Vasut [this message]
2012-08-01 3:48 ` Shawn Guo
2012-07-06 6:17 ` [PATCH 07/10 RESEND] mmc: spi: Pull out common DMA parts from MXS MMC Marek Vasut
2012-07-06 6:17 ` [PATCH 08/10 V2] spi: Add DMA support into SPI driver Marek Vasut
2012-08-01 6:29 ` Marek Vasut
2012-07-06 6:17 ` [PATCH 09/10] spi: Add SSP/SPI device tree documentation Marek Vasut
2012-07-06 6:17 ` [PATCH 10/10] ARM: mx28: Add SPI pinmux into imx28.dtsi Marek Vasut
2012-07-09 16:53 ` [PATCH 01/10 RESEND] mmc: spi: Move SSP register definitions into separate file Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201208010648.05325.marex@denx.de \
--to=marex@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).