* [PATCH v3 12/32] PCI/ARM: use PCIe capabilities access functions to simplify implementation [not found] <1343836477-7287-1-git-send-email-jiang.liu@huawei.com> @ 2012-08-01 15:54 ` Jiang Liu 2012-08-01 17:20 ` Stephen Warren 2012-08-03 18:05 ` Stephen Warren 0 siblings, 2 replies; 4+ messages in thread From: Jiang Liu @ 2012-08-01 15:54 UTC (permalink / raw) To: linux-arm-kernel From: Jiang Liu <jiang.liu@huawei.com> Use PCIe capabilities access functions to simplify PCIe ARM implementation. Signed-off-by: Jiang Liu <liuj97@gmail.com> --- arch/arm/mach-tegra/pcie.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/arch/arm/mach-tegra/pcie.c b/arch/arm/mach-tegra/pcie.c index 0e09137..5f99d33 100644 --- a/arch/arm/mach-tegra/pcie.c +++ b/arch/arm/mach-tegra/pcie.c @@ -367,17 +367,8 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_NVIDIA, 0x0bf1, tegra_pcie_fixup_class); /* Tegra PCIE requires relaxed ordering */ static void __devinit tegra_pcie_relax_enable(struct pci_dev *dev) { - u16 val16; - int pos = pci_find_capability(dev, PCI_CAP_ID_EXP); - - if (pos <= 0) { - dev_err(&dev->dev, "skipping relaxed ordering fixup\n"); - return; - } - - pci_read_config_word(dev, pos + PCI_EXP_DEVCTL, &val16); - val16 |= PCI_EXP_DEVCTL_RELAX_EN; - pci_write_config_word(dev, pos + PCI_EXP_DEVCTL, val16); + pci_pcie_capability_change_word(dev, PCI_EXP_DEVCTL, + PCI_EXP_DEVCTL_RELAX_EN, 0); } DECLARE_PCI_FIXUP_FINAL(PCI_ANY_ID, PCI_ANY_ID, tegra_pcie_relax_enable); -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v3 12/32] PCI/ARM: use PCIe capabilities access functions to simplify implementation 2012-08-01 15:54 ` [PATCH v3 12/32] PCI/ARM: use PCIe capabilities access functions to simplify implementation Jiang Liu @ 2012-08-01 17:20 ` Stephen Warren 2012-08-02 5:58 ` Thierry Reding 2012-08-03 18:05 ` Stephen Warren 1 sibling, 1 reply; 4+ messages in thread From: Stephen Warren @ 2012-08-01 17:20 UTC (permalink / raw) To: linux-arm-kernel On 08/01/2012 09:54 AM, Jiang Liu wrote: > From: Jiang Liu <jiang.liu@huawei.com> > > Use PCIe capabilities access functions to simplify PCIe ARM implementation. > > Signed-off-by: Jiang Liu <liuj97@gmail.com> This is probably fine from my perspective assuming the underlying PCI API implementation is OKd by relevant people. Thierry, can you comment on whether this will conflict with your Tegra PCIe driver series? If it doesn't, this patch can go through any relevant PCI tree. If it does, we may have to take this through the Tegra tree after merging the dependencies, or defer it to later. ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v3 12/32] PCI/ARM: use PCIe capabilities access functions to simplify implementation 2012-08-01 17:20 ` Stephen Warren @ 2012-08-02 5:58 ` Thierry Reding 0 siblings, 0 replies; 4+ messages in thread From: Thierry Reding @ 2012-08-02 5:58 UTC (permalink / raw) To: linux-arm-kernel On Wed, Aug 01, 2012 at 11:20:13AM -0600, Stephen Warren wrote: > On 08/01/2012 09:54 AM, Jiang Liu wrote: > > From: Jiang Liu <jiang.liu@huawei.com> > > > > Use PCIe capabilities access functions to simplify PCIe ARM implementation. > > > > Signed-off-by: Jiang Liu <liuj97@gmail.com> > > This is probably fine from my perspective assuming the underlying PCI > API implementation is OKd by relevant people. > > Thierry, can you comment on whether this will conflict with your Tegra > PCIe driver series? If it doesn't, this patch can go through any > relevant PCI tree. If it does, we may have to take this through the > Tegra tree after merging the dependencies, or defer it to later. I haven't touched those lines. tegra_pcie_relax_enable() only uses generic PCI functions so I don't expect any conflicts. git blame confirms that those lines haven't been changed in about 2 years. Thierry -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120802/eee09477/attachment-0001.sig> ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v3 12/32] PCI/ARM: use PCIe capabilities access functions to simplify implementation 2012-08-01 15:54 ` [PATCH v3 12/32] PCI/ARM: use PCIe capabilities access functions to simplify implementation Jiang Liu 2012-08-01 17:20 ` Stephen Warren @ 2012-08-03 18:05 ` Stephen Warren 1 sibling, 0 replies; 4+ messages in thread From: Stephen Warren @ 2012-08-03 18:05 UTC (permalink / raw) To: linux-arm-kernel On 08/01/2012 09:54 AM, Jiang Liu wrote: > From: Jiang Liu <jiang.liu@huawei.com> > > Use PCIe capabilities access functions to simplify PCIe ARM implementation. > > Signed-off-by: Jiang Liu <liuj97@gmail.com> Acked-by: Stephen Warren <swarren@wwwdotorg.org> ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-08-03 18:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1343836477-7287-1-git-send-email-jiang.liu@huawei.com>
2012-08-01 15:54 ` [PATCH v3 12/32] PCI/ARM: use PCIe capabilities access functions to simplify implementation Jiang Liu
2012-08-01 17:20 ` Stephen Warren
2012-08-02 5:58 ` Thierry Reding
2012-08-03 18:05 ` Stephen Warren
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).