From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: imx: enable emi_slow_gate clock for imx5
Date: Fri, 3 Aug 2012 16:11:08 +0200 [thread overview]
Message-ID: <20120803141108.GV1451@pengutronix.de> (raw)
In-Reply-To: <1343919712-6240-1-git-send-email-shawn.guo@linaro.org>
On Thu, Aug 02, 2012 at 11:01:51PM +0800, Shawn Guo wrote:
> The imx5 common clock migration causes a regression with smsc911x
> driver on imx53-ard board, where a smsc lan9220 controller gets
> connected on imx53 with EIM interface. EIM needs clock emi_slow_gate
> to be functional. In the new imx5 clock driver, there is no use count
> incremented for the clock by enabling it, so the framework closes the
> clock at late init time and makes EIM stop working then.
>
> Enable emi_slow_gate in clock driver initialization to fix the
> regression.
Can we add a comment that emi_slow_gate is needed for the EIM interface?
It's not obvious from the datasheet and this information might help
people who want to clean up the now unconditionally enabled clocks.
Otherwise:
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Sascha
>
> Cc: stable at vger.kernel.org
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> ---
> arch/arm/mach-imx/clk-imx51-imx53.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-imx/clk-imx51-imx53.c b/arch/arm/mach-imx/clk-imx51-imx53.c
> index f608669..6eee32a 100644
> --- a/arch/arm/mach-imx/clk-imx51-imx53.c
> +++ b/arch/arm/mach-imx/clk-imx51-imx53.c
> @@ -303,6 +303,7 @@ static void __init mx5_clocks_common_init(unsigned long rate_ckil,
> clk_prepare_enable(clk[aips_tz2]); /* fec */
> clk_prepare_enable(clk[spba]);
> clk_prepare_enable(clk[emi_fast_gate]); /* fec */
> + clk_prepare_enable(clk[emi_slow_gate]);
> clk_prepare_enable(clk[tmax1]);
> clk_prepare_enable(clk[tmax2]); /* esdhc2, fec */
> clk_prepare_enable(clk[tmax3]); /* esdhc1, esdhc4 */
> --
> 1.7.5.4
>
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2012-08-03 14:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-02 15:01 [PATCH 1/2] ARM: imx: enable emi_slow_gate clock for imx5 Shawn Guo
2012-08-02 15:01 ` [PATCH 2/2] ARM: dts: imx53-ard: add regulators for lan9220 Shawn Guo
2012-08-03 14:11 ` Sascha Hauer [this message]
2012-08-03 14:23 ` [PATCH 1/2] ARM: imx: enable emi_slow_gate clock for imx5 Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120803141108.GV1451@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).