linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] arm: plat-orion: make bridge_virt_base non-const to support DT use case
Date: Fri, 3 Aug 2012 15:48:56 +0200	[thread overview]
Message-ID: <20120803154856.74a5368f@skate> (raw)
In-Reply-To: <201208031341.32744.arnd@arndb.de>

Le Fri, 3 Aug 2012 13:41:32 +0000,
Arnd Bergmann <arnd@arndb.de> a ?crit :

> > +       u32 bridge_virt_base;
> >  
> >         /* If NULL, the default cpu_win_can_remap will be used, using
> >            the value in remappable_wins */
> 
> It would be nice to also change the type of this to void __iomem*, since you are
> already touching the bridge_virt_base.

Yeah, I was also thinking about this cleanup. Will rework my patch
series to include a patch fixing this before doing the other changes.

Thanks!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2012-08-03 13:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-03 13:10 arm: mvebu: Add basic address decoding support for Marvell 370/XP Thomas Petazzoni
2012-08-03 13:10 ` [PATCH 1/4] arm: plat-orion: introduce PLAT_ORION_LEGACY hidden config option Thomas Petazzoni
2012-08-03 13:26   ` Gregory CLEMENT
2012-08-03 13:10 ` [PATCH 2/4] arm: plat-orion: make bridge_virt_base non-const to support DT use case Thomas Petazzoni
2012-08-03 13:27   ` Gregory CLEMENT
2012-08-03 13:41   ` Arnd Bergmann
2012-08-03 13:48     ` Thomas Petazzoni [this message]
2012-08-03 13:10 ` [PATCH 3/4] arm: mvebu: add basic address decoding support to Armada 370/XP Thomas Petazzoni
2012-08-03 13:28   ` Gregory CLEMENT
2012-08-03 13:10 ` [PATCH 4/4] arm: mvebu: add address decoding controller to the DT Thomas Petazzoni
2012-08-03 13:29   ` Gregory CLEMENT
2012-08-03 14:23 ` arm: mvebu: Add basic address decoding support for Marvell 370/XP Arnd Bergmann
2012-08-04 16:27   ` Thomas Petazzoni
2012-08-04 16:50     ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120803154856.74a5368f@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).