From: gregkh@linuxfoundation.org (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] printk: add option to print cpu id
Date: Fri, 3 Aug 2012 15:36:23 -0700 [thread overview]
Message-ID: <20120803223623.GB6156@kroah.com> (raw)
In-Reply-To: <CAFm5wm3ayofPD7oF1=z_jwE_wuqBxBHicAs=KOhjcUr7Jo0wDQ@mail.gmail.com>
On Fri, Aug 03, 2012 at 03:25:17PM -0700, Pandita, Vikram wrote:
> >> This was something that got used internally and helped at times.
> >
> > Could you have used the trace point instead?
>
> As i understood the trace_prink(), one would need to modify existing
> printk -> trace_printk. Is my understanding correct?
No, you should just be able to watch the tracepoint, right?
> Most of the times the problem exhibits as a random hang, without having a clue
> which code to modify. That time one generic defconfig global switch is
> your first tool.
>
> Other issue i found, using this patch, that on multi-core ARM systems,
> almost 99% of times, IRQ's are handled by CPU0,
> even if CPU0 was really busy and other CPU's were free. I am yet to
> understand a good reason why.
Can't you see that from /proc/interrupts today?
> this patch also helped in other areas as mentioned in the thread
> http://marc.info/?l=linux-omap&m=134401269106619&w=2
I still don't understand how adding the cpu number to printk enabled you
to find any problem like this. Can't you just add the cpu number to the
printk messages you care about for your specific hardware?
greg k-h
next prev parent reply other threads:[~2012-08-03 22:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-03 16:56 [PATCH v3] printk: add option to print cpu id Vikram Pandita
2012-08-03 17:54 ` Andi Kleen
2012-08-03 18:25 ` Pandita, Vikram
2012-08-03 20:08 ` Aaro Koskinen
2012-08-03 21:24 ` Pandita, Vikram
2012-08-03 21:59 ` Greg KH
2012-08-03 22:07 ` Pandita, Vikram
2012-08-03 22:13 ` Greg KH
2012-08-03 22:25 ` Pandita, Vikram
2012-08-03 22:36 ` Greg KH [this message]
2012-08-03 22:48 ` Pandita, Vikram
2012-08-06 13:39 ` Steven Rostedt
2012-08-04 8:51 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120803223623.GB6156@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox