From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] ARM: Fix mapping in alloc_init_section for unaligned addresses.
Date: Sat, 4 Aug 2012 09:44:39 +0100 [thread overview]
Message-ID: <20120804084439.GC6802@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1344063622-11021-1-git-send-email-r.sricharan@ti.com>
On Sat, Aug 04, 2012 at 12:30:22PM +0530, R Sricharan wrote:
> When either the start address or end address or physical address
> to be mapped is unaligned, alloc_init_section creates
> page granularity mappings. alloc_init_section calls
> alloc_init_pte which populates one pmd entry and sets up
> the ptes. But if the size is greater than what can be mapped
> by one pmd entry, then the rest remains unmapped.
>
> The issue becomes visible when LPAE is enabled, where we have
> the 3 levels with seperate pgd and pmd's.
> When a static mapping for 3MB is requested, only 2MB is mapped
> and the remaining 1MB is unmapped. Fixing this here, by looping
> in to map the entire unaligned address range.
This doesn't look like a nice fix. The implication above is that it's
only alloc_init_pte() which is affected - so why not add a loop there?
Remember that pte's cover two sections, not one, so you need to use a
different increment to sections.
next prev parent reply other threads:[~2012-08-04 8:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-04 7:00 [PATCH 1/1] ARM: Fix mapping in alloc_init_section for unaligned addresses R Sricharan
2012-08-04 8:44 ` Russell King - ARM Linux [this message]
2012-08-04 10:04 ` R, Sricharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120804084439.GC6802@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox