[PATCH] ARM: mxs_defconfig: Enable USB host

[PATCH] ARM: mxs_defconfig: Enable USB host

[Fabio Estevam]

From: Fabio Estevam <fabio.estevam@freescale.com>

Enable USB host.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 arch/arm/configs/mxs_defconfig |   14 +++++++++++++-
 1 files changed, 13 insertions(+), 1 deletions(-)

diff --git a/arch/arm/configs/mxs_defconfig b/arch/arm/configs/mxs_defconfig
index ccdb635..73842f9 100644
--- a/arch/arm/configs/mxs_defconfig
+++ b/arch/arm/configs/mxs_defconfig
@@ -95,7 +95,7 @@ CONFIG_GPIO_SYSFS=y
 # CONFIG_MFD_SUPPORT is not set
 CONFIG_DISPLAY_SUPPORT=m
 # CONFIG_HID_SUPPORT is not set
-# CONFIG_USB_SUPPORT is not set
+CONFIG_USB_SUPPORT=y
 CONFIG_SOUND=y
 CONFIG_SND=y
 CONFIG_SND_TIMER=y
@@ -110,6 +110,18 @@ CONFIG_SND_SOC_I2C_AND_SPI=y
 CONFIG_SND_SOC_SGTL5000=y
 CONFIG_REGULATOR=y
 CONFIG_REGULATOR_FIXED_VOLTAGE=y
+CONFIG_USB_COMMON=y
+CONFIG_USB_ARCH_HAS_HCD=y
+CONFIG_USB=y
+CONFIG_USB_EHCI_ROOT_HUB_TT=y
+CONFIG_USB_EHCI_TT_NEWSCHED=y
+CONFIG_USB_STORAGE=y
+CONFIG_USB_OTG_UTILS=y
+CONFIG_USB_MXS_PHY=y
+CONFIG_USB_CHIPIDEA=y
+CONFIG_USB_CHIPIDEA_HOST=y
+CONFIG_SCSI=y
+CONFIG_BLK_DEV_SD=y
 CONFIG_MMC=y
 CONFIG_MMC_MXS=y
 CONFIG_RTC_CLASS=y
-- 
1.7.1

[PATCH] ARM: mxs_defconfig: Enable USB host

[Shawn Guo]

On Sun, Aug 05, 2012 at 02:04:18PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Enable USB host.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  arch/arm/configs/mxs_defconfig |   14 +++++++++++++-
>  1 files changed, 13 insertions(+), 1 deletions(-)
> 
I guess you did not run savedefconfig.  We do not need all those
options explicitly added there.

Regards,
Shawn

> diff --git a/arch/arm/configs/mxs_defconfig b/arch/arm/configs/mxs_defconfig
> index ccdb635..73842f9 100644
> --- a/arch/arm/configs/mxs_defconfig
> +++ b/arch/arm/configs/mxs_defconfig
> @@ -95,7 +95,7 @@ CONFIG_GPIO_SYSFS=y
>  # CONFIG_MFD_SUPPORT is not set
>  CONFIG_DISPLAY_SUPPORT=m
>  # CONFIG_HID_SUPPORT is not set
> -# CONFIG_USB_SUPPORT is not set
> +CONFIG_USB_SUPPORT=y
>  CONFIG_SOUND=y
>  CONFIG_SND=y
>  CONFIG_SND_TIMER=y
> @@ -110,6 +110,18 @@ CONFIG_SND_SOC_I2C_AND_SPI=y
>  CONFIG_SND_SOC_SGTL5000=y
>  CONFIG_REGULATOR=y
>  CONFIG_REGULATOR_FIXED_VOLTAGE=y
> +CONFIG_USB_COMMON=y
> +CONFIG_USB_ARCH_HAS_HCD=y
> +CONFIG_USB=y
> +CONFIG_USB_EHCI_ROOT_HUB_TT=y
> +CONFIG_USB_EHCI_TT_NEWSCHED=y
> +CONFIG_USB_STORAGE=y
> +CONFIG_USB_OTG_UTILS=y
> +CONFIG_USB_MXS_PHY=y
> +CONFIG_USB_CHIPIDEA=y
> +CONFIG_USB_CHIPIDEA_HOST=y
> +CONFIG_SCSI=y
> +CONFIG_BLK_DEV_SD=y
>  CONFIG_MMC=y
>  CONFIG_MMC_MXS=y
>  CONFIG_RTC_CLASS=y
> -- 
> 1.7.1
> 

[PATCH] ARM: mxs_defconfig: Enable USB host

[Fabio Estevam]

On Sun, Aug 5, 2012 at 11:58 PM, Shawn Guo <shawn.guo@linaro.org> wrote:

> I guess you did not run savedefconfig.  We do not need all those
> options explicitly added there.

No, I have not run savedefconfig. What is the correct way to use it?

Regards,

Fabio Estevam

[PATCH] ARM: mxs_defconfig: Enable USB host

[Marek Vasut]

Dear Fabio Estevam,

> On Sun, Aug 5, 2012 at 11:58 PM, Shawn Guo <shawn.guo@linaro.org> wrote:
> > I guess you did not run savedefconfig.  We do not need all those
> > options explicitly added there.
> 
> No, I have not run savedefconfig. What is the correct way to use it?

make mxs_config
<edit>
make savedefconfig

I'd guess ...

> Regards,
> 
> Fabio Estevam

Best regards,
Marek Vasut

[PATCH] ARM: mxs_defconfig: Enable USB host

[Fabio Estevam]

On Mon, Aug 6, 2012 at 12:55 AM, Marek Vasut <marek.vasut@gmail.com> wrote:
> Dear Fabio Estevam,
>
>> On Sun, Aug 5, 2012 at 11:58 PM, Shawn Guo <shawn.guo@linaro.org> wrote:
>> > I guess you did not run savedefconfig.  We do not need all those
>> > options explicitly added there.
>>
>> No, I have not run savedefconfig. What is the correct way to use it?
>
> make mxs_config
> <edit>
> make savedefconfig
>
> I'd guess ...

So the generating diff would be:
diff --git a/arch/arm/configs/mxs_defconfig b/arch/arm/configs/mxs_defconfig
index ccdb635..a9556ef 100644
--- a/arch/arm/configs/mxs_defconfig
+++ b/arch/arm/configs/mxs_defconfig
@@ -95,7 +95,7 @@ CONFIG_GPIO_SYSFS=y
 # CONFIG_MFD_SUPPORT is not set
 CONFIG_DISPLAY_SUPPORT=m
 # CONFIG_HID_SUPPORT is not set
-# CONFIG_USB_SUPPORT is not set
+CONFIG_USB_SUPPORT=y
 CONFIG_SOUND=y
 CONFIG_SND=y
 CONFIG_SND_TIMER=y
@@ -110,6 +110,13 @@ CONFIG_SND_SOC_I2C_AND_SPI=y
 CONFIG_SND_SOC_SGTL5000=y
 CONFIG_REGULATOR=y
 CONFIG_REGULATOR_FIXED_VOLTAGE=y
+CONFIG_USB=y
+CONFIG_USB_CHIPIDEA=y
+CONFIG_USB_CHIPIDEA_HOST=y
+CONFIG_USB_STORAGE=y
+CONFIG_USB_MXS_PHY=y
+CONFIG_SCSI=y
+CONFIG_BLK_DEV_SD=y
 CONFIG_MMC=y
 CONFIG_MMC_MXS=y
 CONFIG_RTC_CLASS=y
-- 
1.7.1

Is this OK?

Regards,

Fabio Estevam

[PATCH] ARM: mxs_defconfig: Enable USB host

[Tabi Timur-B04825]

On Sun, Aug 5, 2012 at 10:55 PM, Marek Vasut <marek.vasut@gmail.com> wrote:
>
> make mxs_config
> <edit>
> make savedefconfig

I also hand-diff the two defconfig files so that I only pick up the
relevant changes.

-- 
Timur Tabi
Linux kernel developer at Freescale

[PATCH] ARM: mxs_defconfig: Enable USB host

[Tabi Timur-B04825]

On Sun, Aug 5, 2012 at 11:03 PM, Fabio Estevam <festevam@gmail.com> wrote:

> +CONFIG_SCSI=y
> +CONFIG_BLK_DEV_SD=y

I'm not sure about these two.

Try doing this:

make mxs_config
make savedefconfig

And then compare the two defconfigs.  It will tell you which changes to ignore.

-- 
Timur Tabi
Linux kernel developer at Freescale