linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] OMAP2+: Fix random config build break with !ARM_CPU_SUSPEND
@ 2012-07-13 10:45 Santosh Shilimkar
  2012-08-07  7:23 ` Tony Lindgren
  0 siblings, 1 reply; 2+ messages in thread
From: Santosh Shilimkar @ 2012-07-13 10:45 UTC (permalink / raw)
  To: linux-arm-kernel

The random config builds with PM and !ARM_CPU_SUSPEND breaks with below
error on omap2plus_defconfig.

arch/arm/mach-omap2/sleep44xx.S:323: undefined reference to `cpu_resume'
arch/arm/mach-omap2/omap-mpuss-lowpower.c:278: undefined reference to `cpu_suspend'

This is because recently merged OMAP5 platform shares the common files
with OMAP4 but doesn't select ARM_CPU_SUSPEND. Without the ARM_CPU_SUSPEND
the sleep code is meaningless.

Fix the same by adding ARM_CPU_SUSPEND for OMAP5. The suggestion came from
Russell King in an off-list discussion.

Cc: Russell King <rmk+kernel@arm.linux.org.uk>
Cc: Kevin Hilman <khilman@ti.com>
Reported-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
---
Applies against linux-omap master at commit cb07e339457.

 arch/arm/mach-omap2/Kconfig |    1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
index 2c73f38..976050d 100644
--- a/arch/arm/mach-omap2/Kconfig
+++ b/arch/arm/mach-omap2/Kconfig
@@ -68,6 +68,7 @@ config SOC_OMAP5
 	select CPU_V7
 	select ARM_GIC
 	select HAVE_SMP
+	select ARM_CPU_SUSPEND if PM
 
 comment "OMAP Core Type"
 	depends on ARCH_OMAP2
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] OMAP2+: Fix random config build break with !ARM_CPU_SUSPEND
  2012-07-13 10:45 [PATCH] OMAP2+: Fix random config build break with !ARM_CPU_SUSPEND Santosh Shilimkar
@ 2012-08-07  7:23 ` Tony Lindgren
  0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2012-08-07  7:23 UTC (permalink / raw)
  To: linux-arm-kernel

* Santosh Shilimkar <santosh.shilimkar@ti.com> [120713 03:50]:
> The random config builds with PM and !ARM_CPU_SUSPEND breaks with below
> error on omap2plus_defconfig.
> 
> arch/arm/mach-omap2/sleep44xx.S:323: undefined reference to `cpu_resume'
> arch/arm/mach-omap2/omap-mpuss-lowpower.c:278: undefined reference to `cpu_suspend'
> 
> This is because recently merged OMAP5 platform shares the common files
> with OMAP4 but doesn't select ARM_CPU_SUSPEND. Without the ARM_CPU_SUSPEND
> the sleep code is meaningless.
> 
> Fix the same by adding ARM_CPU_SUSPEND for OMAP5. The suggestion came from
> Russell King in an off-list discussion.

Thanks applying into fixes.

Tony

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-08-07  7:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-13 10:45 [PATCH] OMAP2+: Fix random config build break with !ARM_CPU_SUSPEND Santosh Shilimkar
2012-08-07  7:23 ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).