From: rjw@sisk.pl (Rafael J. Wysocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 11/11] pm/drivers: fix use of SIMPLE_DEV_PM_OPS
Date: Wed, 8 Aug 2012 21:25:55 +0200 [thread overview]
Message-ID: <201208082125.56184.rjw@sisk.pl> (raw)
In-Reply-To: <201208081726.21878.arnd@arndb.de>
On Wednesday, August 08, 2012, Arnd Bergmann wrote:
> On Wednesday 08 August 2012, Takashi Iwai wrote:
> > At Wed, 8 Aug 2012 16:22:29 +0000,
> > Arnd Bergmann wrote:
> > > > Laxman already posted a patch for this, which I'm hoping will make it
> > > > into 3.6, through the I2C tree.
> > > >
> > > > http://www.spinics.net/lists/linux-i2c/msg09359.html
> > >
> > > Ok, dropping this one then.
> >
> > I'm going to fix the similar errors in sound tree tomorrow, too.
> >
>
> Ok. this leaves the omap-rng driver, and my patch comes down to the below.
> Thanks!
Looks good!
Sorry for introducing those warnings in the first place, I should have been
more careful about that.
Thanks,
Rafael
> 8<----
>
> From d83e9e0e5c0e41a0ee2ba6293c8be21e54988f99 Mon Sep 17 00:00:00 2001
> From: Arnd Bergmann <arnd@arndb.de>
> Date: Sat, 4 Aug 2012 07:11:34 +0000
> Subject: [PATCH] omap-rng: fix use of SIMPLE_DEV_PM_OPS
>
> omap_rng_suspend and omap_rng_resume are unused if CONFIG_PM is enabled
> but CONFIG_PM_SLEEP is disabled. I found this while building all defconfig
> files on ARM. It's not clear to me if this is the right solution, but
> at least it makes the code consistent again.
>
> Without this patch, building omap1_defconfig results in:
>
> drivers/char/hw_random/omap-rng.c:165:12: warning: 'omap_rng_suspend' defined but not used [-Wunused-function]
> drivers/char/hw_random/omap-rng.c:171:12: warning: 'omap_rng_resume' defined but not used [-Wunused-function]
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Rafael J. Wysocki <rjw@sisk.pl>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
>
> diff --git a/drivers/char/hw_random/omap-rng.c b/drivers/char/hw_random/omap-rng.c
> index d706bd0e..4fbdceb 100644
> --- a/drivers/char/hw_random/omap-rng.c
> +++ b/drivers/char/hw_random/omap-rng.c
> @@ -160,7 +160,7 @@ static int __exit omap_rng_remove(struct platform_device *pdev)
> return 0;
> }
>
> -#ifdef CONFIG_PM
> +#ifdef CONFIG_PM_SLEEP
>
> static int omap_rng_suspend(struct device *dev)
> {
>
>
>
next prev parent reply other threads:[~2012-08-08 19:25 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-08 14:47 [PATCH 00/11] recently added ARM defconfig warnings Arnd Bergmann
2012-08-08 14:47 ` [PATCH 01/11] ARM: topology: mark init_cpu_topology as __init Arnd Bergmann
2012-08-08 17:53 ` Stephen Boyd
2012-08-08 19:14 ` Arnd Bergmann
2012-08-08 14:47 ` [PATCH 02/11] mfd/asic3: fix asic3_mfd_probe return value Arnd Bergmann
2012-08-08 14:47 ` [PATCH 03/11] usb/ohci-omap: remove unused variable Arnd Bergmann
2012-08-08 15:25 ` Greg Kroah-Hartman
2012-08-08 15:34 ` Alan Stern
2012-08-08 14:47 ` [PATCH 04/11] ARM: ux500: really kill snowball_of_platform_devs Arnd Bergmann
2012-08-08 16:22 ` Lee Jones
2012-08-08 17:19 ` Arnd Bergmann
2012-08-08 14:47 ` [PATCH 05/11] ARM: exynos: exynos_pm_add_dev_to_genpd may be unused Arnd Bergmann
2012-08-10 6:48 ` Kukjin Kim
2012-08-10 6:57 ` Thomas Abraham
2012-08-08 14:47 ` [PATCH 06/11] gpio: em: do not discard em_gio_irq_domain_cleanup Arnd Bergmann
2012-08-10 10:59 ` Linus Walleij
2012-08-10 11:33 ` Arnd Bergmann
2012-08-08 14:47 ` [PATCH 07/11] net/stmmac: mark probe function as __devinit Arnd Bergmann
2012-08-08 15:07 ` Stefan Roese
2012-08-08 23:08 ` David Miller
2012-08-08 14:47 ` [PATCH 08/11] mtd/omap2: fix dmaengine_slave_config error handling Arnd Bergmann
2012-08-08 14:47 ` [PATCH 09/11] regulator/twl: remove fixed resource handling Arnd Bergmann
2012-08-08 14:50 ` Mark Brown
2012-08-08 15:06 ` Arnd Bergmann
2012-08-08 14:47 ` [PATCH 10/11] spi/s3c64xx: improve error handling Arnd Bergmann
2012-08-10 6:39 ` Kukjin Kim
2012-08-10 7:34 ` Arnd Bergmann
2012-08-10 6:58 ` Thomas Abraham
2012-08-08 14:47 ` [PATCH 11/11] pm/drivers: fix use of SIMPLE_DEV_PM_OPS Arnd Bergmann
2012-08-08 15:40 ` Stephen Warren
2012-08-08 16:22 ` Arnd Bergmann
2012-08-08 16:43 ` Takashi Iwai
2012-08-08 17:26 ` Arnd Bergmann
2012-08-08 19:25 ` Rafael J. Wysocki [this message]
2012-08-20 8:32 ` Herbert Xu
2012-08-08 18:11 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201208082125.56184.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).