From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pinctrl: pinctrl-imx: add imx35 pinctrl driver
Date: Fri, 10 Aug 2012 06:45:44 +0200 [thread overview]
Message-ID: <20120810044544.GH25520@pengutronix.de> (raw)
In-Reply-To: <CAP1dx+y7hjPcCHzfL+Axjz-NK12Vq4YkU_UFcXnKhNP0_UT0vw@mail.gmail.com>
Hello,
On Fri, Aug 10, 2012 at 11:14:38AM +0800, Dong Aisheng wrote:
> On 10 August 2012 00:23, Uwe Kleine-K?nig
> <u.kleine-koenig@pengutronix.de> wrote:
> > This is mostly cut'n'paste from the imx51 pinctrl driver. The data was
> > generated using sed and awk on
> > arch/arm/plat-mxc/include/mach/iomux-mx35.h.
> >
> > Cc: Shawn Guo <shawn.guo@linaro.org>
> > Acked-by: Stephen Warren <swarren@wwwdotorg.org>
> > Acked-by: Dong Aisheng <dong.aisheng@linaro.org>
> > Cc: Linus Walleij <linus.walleij@linaro.org>
> > Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> > --
> > Changes since (implicit) v1,
> > id:1343921942-22079-1-git-send-email-u.kleine-koenig at pengutronix.de
> >
> > - remove references to file names in binding documentation
> > - remove sed commands from comments in driver
> > - add explicit numbers for pins and functions
> >
> > @Stephen and Dong: I assumed your ack even though we didn't talk about
> > adding numbers for the functions. If you don't like these please scream
> > before the patch makes it in :-)
> Is that for align with the pin func ids in binding doc?
> It looks no harmful, so i'm ok with it.
Yeah, the idea was to make the (more important) mapping also explicit in
the driver to allow for grepping there.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2012-08-10 4:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-02 15:39 [PATCH] pinctrl: pinctrl-imx: add imx35 pinctrl driver Uwe Kleine-König
2012-08-03 12:25 ` Shawn Guo
2012-08-06 14:23 ` Uwe Kleine-König
2012-08-03 20:37 ` Stephen Warren
2012-08-07 8:04 ` Dong Aisheng
2012-08-07 8:49 ` Uwe Kleine-König
2012-08-07 11:34 ` Dong Aisheng
2012-08-09 17:22 ` Uwe Kleine-König
2012-08-09 16:27 ` Uwe Kleine-König
2012-08-10 11:01 ` Linus Walleij
2012-08-10 12:18 ` Uwe Kleine-König
2012-08-10 12:29 ` Shawn Guo
2012-08-10 3:14 ` Dong Aisheng
2012-08-10 4:45 ` Uwe Kleine-König [this message]
2012-08-13 13:57 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120810044544.GH25520@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).