From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: restart callback not supposed to sleep?
Date: Mon, 20 Aug 2012 09:57:20 +0100 [thread overview]
Message-ID: <20120820085720.GQ18957@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20120820082423.GJ2232@pengutronix.de>
On Mon, Aug 20, 2012 at 10:24:23AM +0200, Uwe Kleine-K?nig wrote:
> while triggering a reboot via sysrq on an ARM machine I saw a "BUG:
> sleeping function called from invalid context" message (details below).
> The reason is that the sysrq handler is calling the restart hook in irq
> context.
Correct - it's been the case for years that the restart hook is called
from atomic contexts (it's not only sysrq, but also softdog as well which
does this, as well as any system panic with panic timeout/panic-on-oops
enabled.)
You need to fix your platform restart hook.
next prev parent reply other threads:[~2012-08-20 8:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 8:24 restart callback not supposed to sleep? Uwe Kleine-König
2012-08-20 8:57 ` Russell King - ARM Linux [this message]
2012-08-20 8:57 ` Lothar Waßmann
2012-08-20 9:05 ` Russell King - ARM Linux
2012-08-20 9:21 ` Uwe Kleine-König
2012-08-20 9:44 ` Russell King - ARM Linux
2012-08-20 9:47 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120820085720.GQ18957@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).