From mboxrd@z Thu Jan  1 00:00:00 1970
From: andrew@lunn.ch (Andrew Lunn)
Date: Mon, 20 Aug 2012 15:25:00 +0200
Subject: [PATCH] ARM: Kirkwood: Iomega_IX2_200 DT support Signed-off-by:
 Alan M Butler <alanbutty12@gmail.com>
In-Reply-To: <CADhrpJ6oH3W9XevfFo52-cxu0zoZ2tmxZuANje01igXeawJP4w@mail.gmail.com>
References: <cover.1345459608.git.alanbutty12@gmail.com>
 <1d07faa52b5ca4453c7eaa7c9decb01af92ee648.1345459608.git.alanbutty12@gmail.com>
 <20120820114320.GB26837@lunn.ch>
 <CADhrpJ6oH3W9XevfFo52-cxu0zoZ2tmxZuANje01igXeawJP4w@mail.gmail.com>
Message-ID: <20120820132500.GC26837@lunn.ch>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

> >> +#include <linux/kernel.h>
> >> +#include <linux/init.h>
> >> +#include <linux/platform_device.h>
> >> +#include <linux/irq.h>
> >> +#include <linux/mtd/partitions.h>
> >> +#include <linux/ata_platform.h>
> >> +#include <linux/mv643xx_eth.h>
> >> +#include <linux/ethtool.h>
> >> +#include <net/dsa.h>
> >> +#include <linux/gpio.h>
> >> +#include <linux/leds.h>
> >> +#include <linux/i2c.h>
> >> +#include <asm/mach-types.h>
> >> +#include <asm/mach/arch.h>
> >> +#include <mach/kirkwood.h>
> >> +#include "common.h"
> >> +#include "mpp.h"
> >
> > It would be good to remove all the unneeded include files.
> >
> >> +
> >> +static struct mv643xx_eth_platform_data iomega_ix2_200_ge00_data = {
> >> +     .phy_addr       = MV643XX_ETH_PHY_NONE,
> >> +     .speed          = SPEED_1000,
> >> +     .duplex         = DUPLEX_FULL,
> >> +};
> >
> > It is somewhat unusual to have this configuration, 1000 full. Is this
> > a hardware limitation? Or is the port connected to an internal switch?
> > Maybe add a comment why its hard coded.
> >
> >       Andrew
> >
> 
> the only 2 includes i can think of that might be able to be removed are:
> 
> #include <linux/ethtool.h>
> #include <net/dsa.h>

I think you can remove a lot more. I _think_ you can remove all these:

#include <linux/irq.h>
#include <linux/mtd/partitions.h>
#include <linux/ata_platform.h>
#include <net/dsa.h>
#include <linux/gpio.h>
#include <linux/leds.h>
#include <linux/i2c.h>

and maybe:

#include <asm/mach-types.h>
#include <asm/mach/arch.h>


Try it and see.

> As for the network that was setup that way in the origional modified
> config file and in uboot on the device it states 2 network devices
> egiga0 and egiga1 i believe it refers to them by but the device only
> has only 1 phisical network interface (egiga1) so i think there must
> be some kind of switch inside.

You should only instantiate the one that is usable, comes outside of
the box. I would delete the other.

	Andrew