From mboxrd@z Thu Jan 1 00:00:00 1970 From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni) Date: Mon, 20 Aug 2012 19:37:34 +0200 Subject: [PATCH 11/11] arm: mvebu: add pinctrl support in defconfig In-Reply-To: <50324FA3.9030005@gmail.com> References: <1344689809-6223-1-git-send-email-sebastian.hesselbarth@gmail.com> <1344689809-6223-12-git-send-email-sebastian.hesselbarth@gmail.com> <50324FA3.9030005@gmail.com> Message-ID: <20120820193734.4fcdbb1a@skate> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Le Mon, 20 Aug 2012 16:54:27 +0200, Sebastian Hesselbarth a ?crit : > On 08/20/2012 04:31 PM, Linus Walleij wrote: > > On Sat, Aug 11, 2012 at 2:56 PM, Sebastian Hesselbarth > > wrote: > >> +CONFIG_PINCTRL_ARMADA_370=y > >> +CONFIG_PINCTRL_ARMADA_XP=y > > > > If the system is not even booting without pinctrl you should > > (IMHO) select these from the machine's Kconfig entry insteaf. > > I don't have a strong opinion on this but I think most systems > will boot just fine without pinctrl. The basic stuff is set up > by u-boot. Anyway, I think we should enable pinctrl for each soc > by default. Yes, the system boots fine without the pinctrl support. So I don't think that MACH_ARMADA_370_XP should forcefully select the pinctrl code, but it's nice to have the default defconfig for this platform select the pinctrl support. Best regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com