linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] ARM: PRIMA2: use DT_MACHINE_START and convert to generic board
Date: Mon, 20 Aug 2012 20:56:28 +0000	[thread overview]
Message-ID: <201208202056.28361.arnd@arndb.de> (raw)
In-Reply-To: <1345450787-17246-2-git-send-email-Barry.Song@csr.com>

On Monday 20 August 2012, Barry Song wrote:
> From: Barry Song <Baohua.Song@csr.com>
> 
> we will have SiRFMarco and SiRFPolo, all of them will be in the
> generic board.
> 
> Signed-off-by: Barry Song <Baohua.Song@csr.com>
> ---
>  arch/arm/mach-prima2/Makefile                      |    2 +-
>  arch/arm/mach-prima2/{prima2.c => board-generic.c} |   10 ++++++----
>  2 files changed, 7 insertions(+), 5 deletions(-)
>  rename arch/arm/mach-prima2/{prima2.c => board-generic.c} (81%)

I would prefer not to have a board-* file in there, because it's not
specific to a board. If you want to get rid of the prima2 name in it,
you can call it common.c.

> diff --git a/arch/arm/mach-prima2/prima2.c b/arch/arm/mach-prima2/board-generic.c
> similarity index 81%
> rename from arch/arm/mach-prima2/prima2.c
> rename to arch/arm/mach-prima2/board-generic.c
> index e9a17ae..f06b887 100644
> --- a/arch/arm/mach-prima2/prima2.c
> +++ b/arch/arm/mach-prima2/board-generic.c
> @@ -30,12 +30,13 @@ void __init sirfsoc_init_late(void)
>  	sirfsoc_pm_init();
>  }
>  
> -static const char *prima2cb_dt_match[] __initdata = {
> -       "sirf,prima2-cb",
> +#ifdef CONFIG_ARCH_PRIMA2
> +static const char *prima2_dt_match[] __initdata = {
> +       "sirf,prima2",
>         NULL
>  };
>  
> -MACHINE_START(PRIMA2_EVB, "prima2cb")
> +DT_MACHINE_START(PRIMA2_DT, "Generic PRIMA2 (Flattened Device Tree)")
>  	/* Maintainer: Barry Song <baohua.song@csr.com> */
>  	.atag_offset	= 0x100,
>  	.map_io         = sirfsoc_map_lluart,
> @@ -44,6 +45,7 @@ MACHINE_START(PRIMA2_EVB, "prima2cb")
>  	.dma_zone_size	= SZ_256M,
>  	.init_machine	= sirfsoc_mach_init,
>  	.init_late	= sirfsoc_init_late,
> -	.dt_compat      = prima2cb_dt_match,
> +	.dt_compat      = prima2_dt_match,
>  	.restart	= sirfsoc_restart,
>  MACHINE_END
> +#endif

I suppose this never really worked before then?

	Arnd

  reply	other threads:[~2012-08-20 20:56 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-20  8:19 [PATCH 0/3] ARM: PRIMA2: some patches prepared to support new SiRF SoCs Barry Song
2012-08-20  8:19 ` [PATCH 1/3] ARM: PRIMA2: use DT_MACHINE_START and convert to generic board Barry Song
2012-08-20 20:56   ` Arnd Bergmann [this message]
2012-08-21  1:49     ` Barry Song
2012-08-21  7:53       ` Arnd Bergmann
2012-08-21  8:26         ` Barry Song
2012-08-21  8:44           ` Arnd Bergmann
2012-08-20  8:19 ` [PATCH 2/3] ARM: PRIMA2: make mach-prima2 common for all SiRF series SoC Barry Song
2012-08-20 21:06   ` Arnd Bergmann
2012-08-21  1:56     ` Barry Song
2012-08-21  7:57       ` Arnd Bergmann
2012-08-21  9:16         ` Barry Song
2012-08-21  9:20           ` Arnd Bergmann
2012-08-28  6:15             ` Barry Song
2012-08-28  8:08               ` Barry Song
2012-08-28 14:28                 ` Stephen Warren
2012-08-28 14:57                   ` Barry Song
2012-08-21  9:29       ` Barry Song
2012-08-21 10:16         ` Arnd Bergmann
2012-08-21  2:06     ` Barry Song
2012-08-21  7:55       ` Arnd Bergmann
2012-08-20  8:19 ` [PATCH 3/3] ARM: SIRF: make sirf irqchip driver selectable since new SoCs will have GIC Barry Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201208202056.28361.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).