From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] serial: pl011: honour serial aliases in device tree
Date: Tue, 21 Aug 2012 21:42:04 +0100 [thread overview]
Message-ID: <20120821204204.GA8316@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <1345564094-16565-1-git-send-email-matthew.leach@arm.com>
Hi Matthew,
On Tue, Aug 21, 2012 at 04:48:14PM +0100, Matthew Leach wrote:
> diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c
> index d3553b5..33c90f6 100644
> --- a/drivers/tty/serial/amba-pl011.c
> +++ b/drivers/tty/serial/amba-pl011.c
> @@ -52,6 +52,8 @@
> #include <linux/scatterlist.h>
> #include <linux/delay.h>
> #include <linux/types.h>
> +#include <linux/of.h>
> +#include <linux/of_device.h>
> #include <linux/pinctrl/consumer.h>
> #include <linux/sizes.h>
>
> @@ -1869,6 +1871,38 @@ static struct uart_driver amba_reg = {
> .cons = AMBA_CONSOLE,
> };
>
> +static int pl011_probe_dt_alias(int index, struct device *dev)
> +{
> + struct device_node *np;
> + static bool seen_dev_with_alias = false;
> + static bool seen_dev_without_alias = false;
> + int ret = index;
> +
> + if (!IS_ENABLED(CONFIG_OF))
> + return index;
May as well return ret here for consistency. With that:
Reviewed-by: Will Deacon <will.deacon@arm.com>
I guess this goes via Greg's tree rather than the ARM one?
Will
next prev parent reply other threads:[~2012-08-21 20:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 15:48 [PATCH v2] serial: pl011: honour serial aliases in device tree Matthew Leach
2012-08-21 20:42 ` Will Deacon [this message]
2012-08-21 22:04 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120821204204.GA8316@mudshark.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).