From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Thu, 23 Aug 2012 14:26:19 +0100 Subject: [PATCH 07/22] ASoC: Ux500: Initialise PCM from MSP probe rather than as a device In-Reply-To: <20120823125903.GA7995@opensource.wolfsonmicro.com> References: <1344527268-5964-1-git-send-email-lee.jones@linaro.org> <1344527268-5964-8-git-send-email-lee.jones@linaro.org> <002801cd7c31$14d3d0c0$3e7b7240$@se> <20120820085111.GJ8450@gmail.com> <006d01cd7f5a$65937840$30ba68c0$@se> <20120823092216.GA27264@gmail.com> <20120823113922.GZ7995@opensource.wolfsonmicro.com> <20120823121936.GA1047@gmail.com> <20120823125903.GA7995@opensource.wolfsonmicro.com> Message-ID: <20120823132618.GB1047@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > > "I'm sorry but this patch is breaking the design of ASoC. The ASoC- > > platform is the DMA-block (in combination with the MSP-block), and > > there should be a platform-driver for the DMA/PCM. The platform-driver > > then has a DAI which is the MSP. The ASoC DAI-link-struct should have > > one driver for each of these, so the dummy-driver for PCM should be > > there." > > > So I don't really know where to go with it. Any ideas? > > I think Ola is suggesting probing the DMA driver from the machine which > will also work though I'm not 100% sure if I'm parsing the above > correctly. The issue in DT terms is that if the DMA controller is > shared with a bunch of other IPs then it should have one node shared > between them all and not a bunch of shim nodes inserted in the middle > which only exists due to the way Linux instantiates stuff. When you say 'machine', do you mean from arch//mach-*? If so, I'm keen for that not to happen. > > How do the all the other DT:ed audio drivers handle the PCM then? More > > importantly, how would you like to see it handled? Ola has NACKed this > > patch and explained why: > > They instantiate the PCM driver dynamically from the DAI when it's > probed which is pretty much what you're patch is doing. So they do it in the same why I have with this patch? Do you know why Ola might think this is a bad idea? -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog