From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] mmc: host: enable OMAP DMA engine support for omap hosts by default
Date: Fri, 24 Aug 2012 10:42:31 +0100 [thread overview]
Message-ID: <20120824094231.GA25765@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <alpine.DEB.2.01.1208240942100.21552@pmeerw.net>
On Fri, Aug 24, 2012 at 09:51:15AM +0200, Peter Meerwald wrote:
> the commit just sets CONFIG_DMA_OMAP=y and CONFIG_DMADEVICES=y in
> omap2plus_defconfig; this does not help people updating the kernel while
> keeping the config, nor does it help people in configuring the kernel
>
> there is a dependency (at least for beagleboard) between MMC_OMAP_HS and
> DMA_OMAP, and I think this should be made explicit
Well, this is where stuff starts to get really yucky, because that
means if you have DMA_OMAP as a module, you have to have MMC_OMAP_HS
as a module too. Or vice versa. Which is a real pain for further
development of DMA_OMAP.
Whatever, the solution here is NOT to add select statements to the
Kconfig to force DMA engine support and DMA_OMAP to 'y' for OMAP.
The best solution is for MMC_OMAP_HS to depend on DMA_OMAP, but that
will just mean that you'll end up with MMC_OMAP_HS disabled in your
config witout DMA engine support. Another less desirable solution
is to have MMC_OMAP_HS select DMA engine and DMA_OMAP.
next prev parent reply other threads:[~2012-08-24 9:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1342485005-5178-1-git-send-email-javier@dowhile0.org>
2012-07-17 6:45 ` [PATCH 1/1] mmc: host: enable OMAP DMA engine support for omap hosts by default Shilimkar, Santosh
2012-07-17 6:51 ` Javier Martinez Canillas
2012-07-18 6:59 ` Tony Lindgren
2012-07-18 7:04 ` Shilimkar, Santosh
2012-07-18 7:10 ` Tony Lindgren
2012-07-18 7:44 ` S, Venkatraman
2012-07-18 8:36 ` Shilimkar, Santosh
2012-07-18 8:49 ` Javier Martinez Canillas
2012-07-18 9:11 ` Shilimkar, Santosh
2012-07-18 9:16 ` Javier Martinez Canillas
2012-07-18 9:38 ` S, Venkatraman
2012-07-18 9:44 ` Shilimkar, Santosh
2012-07-19 11:32 ` Tony Lindgren
2012-07-20 9:28 ` S, Venkatraman
2012-07-20 10:01 ` S, Venkatraman
2012-08-23 21:00 ` Peter Meerwald
2012-08-24 7:10 ` Shilimkar, Santosh
2012-08-24 7:51 ` Peter Meerwald
2012-08-24 9:42 ` Russell King - ARM Linux [this message]
2012-08-24 10:21 ` Shilimkar, Santosh
2012-08-24 10:39 ` Russell King - ARM Linux
2012-08-24 10:45 ` Shilimkar, Santosh
2012-08-24 12:10 ` Peter Meerwald
2012-08-25 7:57 ` Russell King - ARM Linux
2012-07-18 8:25 ` Javier Martinez Canillas
2012-07-19 11:31 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120824094231.GA25765@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).